From: Tanay Abhra <tanayabh@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v6 2/2] test-config: Add tests for the config_set API
Date: Wed, 09 Jul 2014 16:45:08 +0530 [thread overview]
Message-ID: <53BD243C.6010907@gmail.com> (raw)
In-Reply-To: <vpqvbr9w154.fsf@anie.imag.fr>
On 7/7/2014 10:34 PM, Matthieu Moy wrote:
> Tanay Abhra <tanayabh@gmail.com> writes:
>
>> diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh
>> new file mode 100755
>> index 0000000..ad99f8b
>> --- /dev/null
>> +++ b/t/t1308-config-hash.sh
>> +test_expect_success 'setup default config' '
>> + cat >.git/config << EOF
>
> Missing && here (sorry, I should have noticed the first time).
>
Does a single cat command warrant a `&&`? It errors out when I try
to add it there.
next prev parent reply other threads:[~2014-07-09 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 7:52 [PATCH v6 0/3] git config cache & special querying api utilizing the cache Tanay Abhra
2014-07-07 7:52 ` [PATCH v6 1/2] add `config_set` API for caching config-like files Tanay Abhra
2014-07-07 7:52 ` [PATCH v6 2/2] test-config: Add tests for the config_set API Tanay Abhra
2014-07-07 17:04 ` Matthieu Moy
2014-07-09 11:15 ` Tanay Abhra [this message]
2014-07-09 12:10 ` Matthieu Moy
2014-07-07 17:10 ` [PATCH v6 0/3] git config cache & special querying api utilizing the cache Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD243C.6010907@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).