git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karsten Blees <karsten.blees@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	Git List <git@vger.kernel.org>,
	 msysGit <msysgit@googlegroups.com>
Subject: [PATCH v8 01/17] trace: move trace declarations from cache.h to new trace.h
Date: Sat, 12 Jul 2014 01:57:52 +0200	[thread overview]
Message-ID: <53C07A00.6010708@gmail.com> (raw)
In-Reply-To: <53C079C5.8090503@gmail.com>

Also include direct dependencies (strbuf.h and git-compat-util.h for
__attribute__) so that trace.h can be used independently of cache.h, e.g.
in test programs.

Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 cache.h | 13 ++-----------
 trace.h | 17 +++++++++++++++++
 2 files changed, 19 insertions(+), 11 deletions(-)
 create mode 100644 trace.h

diff --git a/cache.h b/cache.h
index cbe1935..466f6b3 100644
--- a/cache.h
+++ b/cache.h
@@ -7,6 +7,7 @@
 #include "advice.h"
 #include "gettext.h"
 #include "convert.h"
+#include "trace.h"
 
 #include SHA1_HEADER
 #ifndef git_SHA_CTX
@@ -1377,17 +1378,7 @@ extern void *alloc_tag_node(void);
 extern void *alloc_object_node(void);
 extern void alloc_report(void);
 
-/* trace.c */
-__attribute__((format (printf, 1, 2)))
-extern void trace_printf(const char *format, ...);
-__attribute__((format (printf, 2, 3)))
-extern void trace_argv_printf(const char **argv, const char *format, ...);
-extern void trace_repo_setup(const char *prefix);
-extern int trace_want(const char *key);
-__attribute__((format (printf, 2, 3)))
-extern void trace_printf_key(const char *key, const char *fmt, ...);
-extern void trace_strbuf(const char *key, const struct strbuf *buf);
-
+/* pkt-line.c */
 void packet_trace_identity(const char *prog);
 
 /* add */
diff --git a/trace.h b/trace.h
new file mode 100644
index 0000000..6cc4541
--- /dev/null
+++ b/trace.h
@@ -0,0 +1,17 @@
+#ifndef TRACE_H
+#define TRACE_H
+
+#include "git-compat-util.h"
+#include "strbuf.h"
+
+__attribute__((format (printf, 1, 2)))
+extern void trace_printf(const char *format, ...);
+__attribute__((format (printf, 2, 3)))
+extern void trace_argv_printf(const char **argv, const char *format, ...);
+extern void trace_repo_setup(const char *prefix);
+extern int trace_want(const char *key);
+__attribute__((format (printf, 2, 3)))
+extern void trace_printf_key(const char *key, const char *fmt, ...);
+extern void trace_strbuf(const char *key, const struct strbuf *buf);
+
+#endif /* TRACE_H */
-- 
2.0.0.406.g2e9ef9b

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2014-07-11 23:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 23:56 [PATCH v8 00/17] add performance tracing facility Karsten Blees
2014-07-11 23:57 ` Karsten Blees [this message]
2014-07-11 23:58 ` [PATCH v8 02/17] trace: consistently name the format parameter Karsten Blees
2014-07-11 23:59 ` [PATCH v8 03/17] trace: remove redundant printf format attribute Karsten Blees
2014-07-12  0:00 ` [PATCH v8 04/17] trace: improve trace performance Karsten Blees
2014-07-12  0:00 ` [PATCH v8 05/17] Documentation/git.txt: improve documentation of 'GIT_TRACE*' variables Karsten Blees
2014-07-12  0:01 ` [PATCH v8 06/17] sha1_file: change GIT_TRACE_PACK_ACCESS logging to use trace API Karsten Blees
2014-07-12  0:02 ` [PATCH v8 07/17] trace: add infrastructure to augment trace output with additional info Karsten Blees
2014-07-12  0:03 ` [PATCH v8 08/17] trace: disable additional trace output for unit tests Karsten Blees
2014-07-12  0:03 ` [PATCH v8 09/17] trace: add current timestamp to all trace output Karsten Blees
2014-07-12  0:04 ` [PATCH v8 10/17] trace: move code around, in preparation to file:line output Karsten Blees
2014-07-12  0:05 ` [PATCH v8 11/17] trace: add 'file:line' to all trace output Karsten Blees
2014-07-12  0:05 ` [PATCH v8 12/17] trace: add high resolution timer function to debug performance issues Karsten Blees
2014-07-12  0:06 ` [PATCH v8 13/17] trace: add trace_performance facility " Karsten Blees
2014-07-12  0:07 ` [PATCH v8 14/17] git: add performance tracing for git's main() function to debug scripts Karsten Blees
2014-07-12  0:07 ` [PATCH v8 15/17] wt-status: simplify performance measurement by using getnanotime() Karsten Blees
2014-07-12  0:08 ` [PATCH v8 16/17] progress: " Karsten Blees
2014-07-12  0:08 ` [PATCH v8 17/17] api-trace.txt: add trace API documentation Karsten Blees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C07A00.6010708@gmail.com \
    --to=karsten.blees@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).