From: Karsten Blees <karsten.blees@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
msysGit <msysgit@googlegroups.com>
Subject: [PATCH v8 03/17] trace: remove redundant printf format attribute
Date: Sat, 12 Jul 2014 01:59:21 +0200 [thread overview]
Message-ID: <53C07A59.3020702@gmail.com> (raw)
In-Reply-To: <53C079C5.8090503@gmail.com>
trace_printf_key() is the only non-static function that duplicates the
printf format attribute in the .c file, remove it for consistency.
Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
trace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/trace.c b/trace.c
index 37a7fa9..3e31558 100644
--- a/trace.c
+++ b/trace.c
@@ -75,7 +75,6 @@ static void trace_vprintf(const char *key, const char *format, va_list ap)
strbuf_release(&buf);
}
-__attribute__((format (printf, 2, 3)))
void trace_printf_key(const char *key, const char *format, ...)
{
va_list ap;
--
2.0.0.406.g2e9ef9b
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-07-11 23:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 23:56 [PATCH v8 00/17] add performance tracing facility Karsten Blees
2014-07-11 23:57 ` [PATCH v8 01/17] trace: move trace declarations from cache.h to new trace.h Karsten Blees
2014-07-11 23:58 ` [PATCH v8 02/17] trace: consistently name the format parameter Karsten Blees
2014-07-11 23:59 ` Karsten Blees [this message]
2014-07-12 0:00 ` [PATCH v8 04/17] trace: improve trace performance Karsten Blees
2014-07-12 0:00 ` [PATCH v8 05/17] Documentation/git.txt: improve documentation of 'GIT_TRACE*' variables Karsten Blees
2014-07-12 0:01 ` [PATCH v8 06/17] sha1_file: change GIT_TRACE_PACK_ACCESS logging to use trace API Karsten Blees
2014-07-12 0:02 ` [PATCH v8 07/17] trace: add infrastructure to augment trace output with additional info Karsten Blees
2014-07-12 0:03 ` [PATCH v8 08/17] trace: disable additional trace output for unit tests Karsten Blees
2014-07-12 0:03 ` [PATCH v8 09/17] trace: add current timestamp to all trace output Karsten Blees
2014-07-12 0:04 ` [PATCH v8 10/17] trace: move code around, in preparation to file:line output Karsten Blees
2014-07-12 0:05 ` [PATCH v8 11/17] trace: add 'file:line' to all trace output Karsten Blees
2014-07-12 0:05 ` [PATCH v8 12/17] trace: add high resolution timer function to debug performance issues Karsten Blees
2014-07-12 0:06 ` [PATCH v8 13/17] trace: add trace_performance facility " Karsten Blees
2014-07-12 0:07 ` [PATCH v8 14/17] git: add performance tracing for git's main() function to debug scripts Karsten Blees
2014-07-12 0:07 ` [PATCH v8 15/17] wt-status: simplify performance measurement by using getnanotime() Karsten Blees
2014-07-12 0:08 ` [PATCH v8 16/17] progress: " Karsten Blees
2014-07-12 0:08 ` [PATCH v8 17/17] api-trace.txt: add trace API documentation Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C07A59.3020702@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).