From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karsten Blees Subject: Re: [PATCH v1 1/3] dir.c: coding style fix Date: Tue, 15 Jul 2014 20:57:56 +0200 Message-ID: <53C579B4.2050506@gmail.com> References: <53C3A71F.1020101@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Git List , Duy Nguyen To: Junio C Hamano X-From: git-owner@vger.kernel.org Tue Jul 15 20:58:03 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X77vO-0006Rt-GQ for gcvg-git-2@plane.gmane.org; Tue, 15 Jul 2014 20:58:02 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932843AbaGOS56 convert rfc822-to-quoted-printable (ORCPT ); Tue, 15 Jul 2014 14:57:58 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:48554 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932734AbaGOS55 (ORCPT ); Tue, 15 Jul 2014 14:57:57 -0400 Received: by mail-wg0-f46.google.com with SMTP id m15so6039913wgh.17 for ; Tue, 15 Jul 2014 11:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=g7+3PNoNMOP1A8FOMO3iJcPvyH41luR+ao4x/ofvTDI=; b=bRrIpse86XvarspatL2aCN5JX87wqtct8YM8CzhgjtLHjRZRoaWl7NuUeYuEefBgki XgHuzC+ljGQA3tiXvPul4sOjx3eON2avITwoqoxmFi/TJTisVDLAvduk7gdQJ1LmKqT2 EVpqnqpP5STW4RlvbMEVRtCKZ673BoxcgI4S6kPGhJgGXCmhra8KLl9ufLSMEgYe8xXG SfwTHhWPBZe7MfqJ8foDRCF5op8+7HiciD6o03MOVBFsD391mdlFrXnTrXcut230+bR/ MMCOzonkpbwr6CG82C3Lklb7ybDFjT9MIuEnE7/zrrI/YTDwGEcM/Cbb8ngzBfbfPzqC UJsA== X-Received: by 10.194.222.197 with SMTP id qo5mr30777348wjc.78.1405450675793; Tue, 15 Jul 2014 11:57:55 -0700 (PDT) Received: from [10.1.116.52] (ns.dcon.de. [77.244.111.149]) by mx.google.com with ESMTPSA id v17sm34390812wjr.33.2014.07.15.11.57.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Jul 2014 11:57:55 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Am 15.07.2014 00:30, schrieb Junio C Hamano: > Karsten Blees writes: >=20 >> From: =3D?UTF-8?q?Nguy=3DE1=3DBB=3D85n=3D20Th=3DC3=3DA1i=3D20Ng=3DE1= =3DBB=3D8Dc=3D20Duy?=3D >> >> >> Signed-off-by: Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy >> Signed-off-by: Karsten Blees >> --- >=20 > Thanks for forwarding. I'll fix-up the Yikes (see how these two > lines show the same name in a very different way), but how did you > produce the above? Is there some fix we need in the toolchain that > produces patch e-mails? >=20 Hmmm...I simply thought that this is how its supposed to work. Mail headers can only contain US-ASCII, so the RFC 2047 Q-encoded-word generated by git-format-patch looked good to me. It seems git-mailinfo doesn't handle line breaks in header lines in the mail body. I.e. if you remove the LF in the 'From:' line, everything is fine, despite the Q-encoding. Now, 'git-format-patch --from' seems to work around the problem, but only for the 'From:' line. AFAICT there's no such option for 'Subject:', e.g. if you want to paste a patch after a scissors line, you're on your own (see the example in the git-format-patch(1) discussion section, with 'Subject:' both Q-encoded and line-wrapped). Perhaps it should be clarified that git-format-patch output is not suitable for pasting into mail clients? Or it should print headers in plain text and let git-send-email handle the conversions?