git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Felix <ted@tedfelix.com>
To: John Keeping <john@keeping.me.uk>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 2/2] rebase: omit patch-identical commits with --fork-point
Date: Wed, 16 Jul 2014 17:36:03 -0400	[thread overview]
Message-ID: <53C6F043.7090209@tedfelix.com> (raw)
In-Reply-To: <374b26180807c67f7bd152ce5a2f52e34397e3a6.1405538598.git.john@keeping.me.uk>

On 07/16/2014 03:23 PM, John Keeping wrote:
> Change from v1:
>      - add a test case

Test case is working fine for me.  It passes with the patch and fails 
without.  However, it does seem to cause all the rest of the test cases 
to fail if it fails.  Is there some cleanup missing?

Ted.

  parent reply	other threads:[~2014-07-16 21:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 15:14 [BUG] rebase no longer omits local commits Ted Felix
2014-07-03 19:09 ` John Keeping
2014-07-03 22:25   ` John Keeping
2014-07-07 17:56     ` Junio C Hamano
2014-07-07 21:14       ` John Keeping
2014-07-15 19:14         ` [PATCH 1/2] rebase--am: use --cherry-pick instead of --ignore-if-in-upstream John Keeping
2014-07-15 19:14           ` [PATCH 2/2] rebase: omit patch-identical commits with --fork-point John Keeping
2014-07-15 19:48             ` Ted Felix
2014-07-15 22:06             ` Junio C Hamano
2014-07-16 19:23               ` [PATCH v2 1/2] rebase--am: use --cherry-pick instead of --ignore-if-in-upstream John Keeping
2014-07-16 19:23                 ` [PATCH v2 2/2] rebase: omit patch-identical commits with --fork-point John Keeping
2014-07-16 20:26                   ` Junio C Hamano
2014-07-16 21:27                     ` John Keeping
2014-07-16 21:36                   ` Ted Felix [this message]
2014-07-17  9:36                     ` John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C6F043.7090209@tedfelix.com \
    --to=ted@tedfelix.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=john@keeping.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).