From: "René Scharfe" <l.s.r@web.de>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Karsten Blees <karsten.blees@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] wrapper: add xgetcwd()
Date: Sun, 20 Jul 2014 17:22:41 +0200 [thread overview]
Message-ID: <53CBDEC1.7010800@web.de> (raw)
In-Reply-To: <CACsJy8BUaAkO8_fjGCtVDyoSKkBQ+VKJLtjN_HZfV7XHOnS_yA@mail.gmail.com>
Am 20.07.2014 14:35, schrieb Duy Nguyen:
> On Sun, Jul 20, 2014 at 6:21 PM, René Scharfe <l.s.r@web.de> wrote:
>> +char *xgetcwd(void)
>> +{
>> + struct strbuf sb = STRBUF_INIT;
>> + if (strbuf_add_cwd(&sb))
>> + die_errno("unable to get current working directory");
>
> Wrap the string with _() to make it translatable? I can't see why any
> script would want to grep this string..
Sure, good idea.
>
>> + return strbuf_detach(&sb, NULL);
>> +}
Thank you for the review,
René
next prev parent reply other threads:[~2014-07-20 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 11:18 [PATCH 0/3] getcwd without PATH_MAX René Scharfe
2014-07-20 11:21 ` [PATCH 1/3] strbuf: add strbuf_add_cwd() René Scharfe
2014-07-20 12:33 ` Duy Nguyen
2014-07-20 15:21 ` René Scharfe
2014-07-20 11:21 ` [PATCH 2/3] wrapper: add xgetcwd() René Scharfe
2014-07-20 12:35 ` Duy Nguyen
2014-07-20 15:22 ` René Scharfe [this message]
2014-07-20 11:22 ` [PATCH 3/3] use xgetcwd() get the current directory or die René Scharfe
2014-07-20 12:45 ` Duy Nguyen
2014-07-20 15:21 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CBDEC1.7010800@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).