From: Tanay Abhra <tanayabh@gmail.com>
To: git@vger.kernel.org
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v4 3/6] rewrite git_config() to use the config-set API
Date: Tue, 29 Jul 2014 17:05:21 +0530 [thread overview]
Message-ID: <53D786F9.9070002@gmail.com> (raw)
In-Reply-To: <1406633302-23144-4-git-send-email-tanayabh@gmail.com>
> diff --git a/t/t4055-diff-context.sh b/t/t4055-diff-context.sh
> index cd04543..741e080 100755
> --- a/t/t4055-diff-context.sh
> +++ b/t/t4055-diff-context.sh
> @@ -79,7 +79,7 @@ test_expect_success 'non-integer config parsing' '
> test_expect_success 'negative integer config parsing' '
> git config diff.context -1 &&
> test_must_fail git diff 2>output &&
> - test_i18ngrep "bad config file" output
> + test_i18ngrep "bad config variable" output
> '
>
> test_expect_success '-U0 is valid, so is diff.context=0' '
>
This was a minor fixup with only a changed word, so I didn't flip it and
fix after in the series as you said yesterday. Dunno if it's alright.
next prev parent reply other threads:[~2014-07-29 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 11:28 [PATCH v4 0/6] Rewrite `git_config()` using config-set API Tanay Abhra
2014-07-29 11:28 ` [PATCH v4 1/6] config.c: fix accuracy of line number in errors Tanay Abhra
2014-07-29 11:28 ` [PATCH v4 2/6] add line number and file name info to `config_set` Tanay Abhra
2014-07-29 11:28 ` [PATCH v4 3/6] rewrite git_config() to use the config-set API Tanay Abhra
2014-07-29 11:35 ` Tanay Abhra [this message]
2014-07-29 12:38 ` Matthieu Moy
2014-07-29 12:40 ` Matthieu Moy
2014-07-29 13:32 ` Tanay Abhra
2014-07-29 14:03 ` Matthieu Moy
2014-07-29 17:49 ` Tanay Abhra
2014-07-29 11:28 ` [PATCH v4 4/6] add a test for semantic errors in config files Tanay Abhra
2014-07-29 11:28 ` [PATCH v4 5/6] config: add `git_die_config()` to the config-set API Tanay Abhra
2014-07-29 11:28 ` [PATCH v4 6/6] add tests for `git_config_get_string_const()` Tanay Abhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D786F9.9070002@gmail.com \
--to=tanayabh@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).