From: Bernhard Reiter <ockham@raz.or.at>
To: git@vger.kernel.org
Subject: [PATCH] git-imap-send: simplify tunnel construction
Date: Wed, 13 Aug 2014 19:30:43 +0200 [thread overview]
Message-ID: <53EBA0C3.2040805@raz.or.at> (raw)
[-- Attachment #1: Type: text/plain, Size: 129 bytes --]
Signed-off-by: Bernhard Reiter <ockham@raz.or.at>
---
imap-send.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[-- Attachment #2: 0001-git-imap-send-simplify-tunnel-construction.patch --]
[-- Type: text/x-patch, Size: 747 bytes --]
diff --git a/imap-send.c b/imap-send.c
index 524fbab..fb01a9c 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -961,17 +961,16 @@ static struct imap_store *imap_open_store(struct imap_server_conf *srvc)
/* open connection to IMAP server */
if (srvc->tunnel) {
- const char *argv[] = { srvc->tunnel, NULL };
struct child_process tunnel = {NULL};
imap_info("Starting tunnel '%s'... ", srvc->tunnel);
- tunnel.argv = argv;
+ argv_array_push(&tunnel.args, srvc->tunnel);
tunnel.use_shell = 1;
tunnel.in = -1;
tunnel.out = -1;
if (start_command(&tunnel))
- die("cannot start proxy %s", argv[0]);
+ die("cannot start proxy %s", srvc->tunnel);
imap->buf.sock.fd[0] = tunnel.out;
imap->buf.sock.fd[1] = tunnel.in;
next reply other threads:[~2014-08-13 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 17:30 Bernhard Reiter [this message]
2014-08-17 7:30 ` [PATCH] git-imap-send: simplify tunnel construction Jeff King
2014-08-18 17:00 ` Junio C Hamano
2014-08-18 17:15 ` Bernhard Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EBA0C3.2040805@raz.or.at \
--to=ockham@raz.or.at \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).