From: Petr Stodulka <pstodulk@redhat.com>
To: git@vger.kernel.org
Subject: Re: [BUG] resolved deltas
Date: Thu, 21 Aug 2014 20:25:39 +0200 [thread overview]
Message-ID: <53F639A3.80805@redhat.com> (raw)
In-Reply-To: <53F5D98F.4040700@redhat.com>
> <snip>
> Bug is reprodusible since git version 1.8.3.1 (may earlier 1.8.xx, but
> I don't test it) to actual upstream version.
> This problem "doesn't exists" in version 1.7.xx - or more precisely is
> not reproducible. "May" this is reproducible
> since commit "7218a215" - in this commit was added assert in file
> "builtin/index-pack.c" (actual line is 918), but I didn't test this.
Ok so this is reproducible since this commit because of assert().
> Here I am lost. I don't know really what I can do next here, because I
> don't understand some ideas in code. e.g. searching of child -
> functions find_delta(), find_delta_children(). Calculation on line 618:
> ----
> int next = (first+last) / 2;
> ----
> I still don't understand. I didn't find description of this searching
> algorithm in tech. documentation but I didn't read all yet. However I
> think that source of problems could be somewhere in these two
> functions. When child is found, its real_type is set to parent's type
> in function resolve_delta() on the line 865 and then lasts wait for
> failure. I don't think that problem is in repository itself [1], but
> it is possible.
I read history of commits and my idea seems to be incorrect. It seems
more like some error in repository itself. But I'd rather get opinion
from someone who knows this code and ideas better.
Regards,
Petr
> [0] https://bugzilla.redhat.com/show_bug.cgi?id=1099919
> [1] git clone https://code.google.com/p/mapsforge/ mapsforge.git
next prev parent reply other threads:[~2014-08-21 18:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 11:35 [BUG] resolved deltas Petr Stodulka
2014-08-21 18:25 ` Petr Stodulka [this message]
2014-08-22 19:41 ` Martin von Gagern
2014-08-23 10:12 ` René Scharfe
2014-08-23 10:56 ` Jeff King
2014-08-23 11:04 ` Jeff King
2014-08-23 11:18 ` Jeff King
2014-08-25 16:39 ` René Scharfe
2014-08-28 22:08 ` Jeff King
2014-08-28 22:15 ` Jeff King
2014-08-28 23:04 ` Jeff King
2014-08-28 22:22 ` Jeff King
2014-08-28 23:14 ` Junio C Hamano
2014-08-29 20:55 ` Jeff King
2014-08-29 20:57 ` [PATCH 1/2] index-pack: fix race condition with duplicate bases Jeff King
2014-08-29 20:58 ` [PATCH 2/2] index-pack: handle duplicate base objects gracefully Jeff King
2014-08-29 21:56 ` Junio C Hamano
2014-08-29 22:08 ` Jeff King
2014-08-30 2:59 ` Shawn Pearce
2014-08-30 13:16 ` Jeff King
2014-08-30 16:00 ` René Scharfe
2014-08-31 15:17 ` Jeff King
2014-08-31 16:30 ` René Scharfe
2014-08-31 1:10 ` Shawn Pearce
2014-08-31 15:24 ` Jeff King
2014-08-31 22:23 ` Junio C Hamano
2014-08-30 13:23 ` [PATCH 3/2] t5309: mark delta-cycle failover tests as passing Jeff King
2014-08-31 15:15 ` Jeff King
2014-09-02 17:19 ` Junio C Hamano
2014-08-25 17:19 ` [BUG] resolved deltas Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F639A3.80805@redhat.com \
--to=pstodulk@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).