From: "Torsten Bögershausen" <tboegi@web.de>
To: Maxim Bublis <satori@yandex-team.ru>, git@vger.kernel.org
Subject: Re: [PATCH] contrib/svn-fe: fix Makefile
Date: Tue, 26 Aug 2014 11:31:48 +0200 [thread overview]
Message-ID: <53FC5404.7050403@web.de> (raw)
In-Reply-To: <1409057062-72857-1-git-send-email-satori@yandex-team.ru>
On 08/26/2014 02:44 PM, Maxim Bublis wrote:
> Fixes several problems:
> * include config.mak.uname, config.mak.autogen and config.mak
> in order to use settings for prefix and other such things;
> * link xdiff/lib.a as it is a requirement for libgit.a;
> * fix CFLAGS and EXTLIBS for Linux and Mac OS X.
> ---
> contrib/svn-fe/Makefile | 47 ++++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 38 insertions(+), 9 deletions(-)
>
> diff --git a/contrib/svn-fe/Makefile b/contrib/svn-fe/Makefile
> index 360d8da..8e1d622 100644
> --- a/contrib/svn-fe/Makefile
> +++ b/contrib/svn-fe/Makefile
> @@ -1,18 +1,45 @@
> all:: svn-fe$X
>
> -CC = gcc
> +CC = cc
> RM = rm -f
> MV = mv
>
> CFLAGS = -g -O2 -Wall
> LDFLAGS =
> -ALL_CFLAGS = $(CFLAGS)
> -ALL_LDFLAGS = $(LDFLAGS)
> -EXTLIBS =
> +EXTLIBS = -lz
> +
> +include ../../config.mak.uname
> +-include ../../config.mak.autogen
> +-include ../../config.mak
> +
> +ifeq ($(uname_S),Darwin)
> + CFLAGS += -I/opt/local/include
> + LDFLAGS += -L/opt/local/lib
> +endif
> +
Should it be possible to disable this by using NO_DARWIN_PORTS
like we do in the main Makefile ?
next prev parent reply other threads:[~2014-08-26 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 12:44 [PATCH] contrib/svn-fe: fix Makefile Maxim Bublis
2014-08-26 9:31 ` Torsten Bögershausen [this message]
2014-08-27 17:36 ` Maxim Bublis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC5404.7050403@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=satori@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).