From: Mark Levedahl <mlevedahl@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>, johannes.schindelin@gmx.de
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git v2.49.0 - gitk regression on Cygwin
Date: Sat, 29 Mar 2025 17:49:59 -0400 [thread overview]
Message-ID: <53c31331-97ed-48be-8399-2701581b09a9@gmail.com> (raw)
In-Reply-To: <7b4149e1-44f8-44d4-89f8-647734f9e674@kdbg.org>
On 3/28/25 1:30 PM, Johannes Sixt wrote:
> Indeed, it seems that this override is only needed on Windows. Dscho, is
> there a non-obvious reason that 'exec' and 'open' are overridden on all
> platforms?
>
> -- Hannes
>
(resending to avoid HTML ...)
Looking at git-gui's history, I see no deliberate decision to alter the
native path search on any platform except Windows, just no effort ever
to leave non-Windows platforms alone. The buggy Cygwin code is part of
what I excised from git-gui in 2023 (commit 7145c654 on the git-gui tree).
I'll plan to send a patch for gitk to revert non-windows platforms to
native functions in a couple of days. This idea applies also to git-gui.
Mark
next prev parent reply other threads:[~2025-03-29 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 12:34 git v2.49.0 - gitk regression on Cygwin Mark Levedahl
2025-03-28 17:30 ` Johannes Sixt
2025-03-29 21:49 ` Mark Levedahl [this message]
2025-03-31 15:12 ` [PATCH] gitk - override $PATH search only on Windows Mark Levedahl
2025-03-31 17:12 ` Johannes Sixt
2025-03-31 19:29 ` Mark Levedahl
2025-04-01 3:00 ` [PATCH v2 0/3] gitk: override PATH " Mark Levedahl
2025-04-01 3:01 ` [PATCH v2 1/3] gitk: override $PATH " Mark Levedahl
2025-04-01 3:01 ` [PATCH v2 2/3] gitk: _search_exe is no longer needed Mark Levedahl
2025-04-01 3:01 ` [PATCH v2 3/3] gitk: limit PATH search to bare executable names Mark Levedahl
2025-04-01 16:10 ` [PATCH v2 0/3] gitk: override PATH search only on Windows Johannes Schindelin
2025-04-01 16:44 ` Mark Levedahl
2025-04-01 16:40 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53c31331-97ed-48be-8399-2701581b09a9@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).