From: Jonathan Chang <ttjtftx@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Jonathan Chang" <ttjtftx@gmail.com>,
"Christian Couder" <christian.couder@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty function
Date: Sat, 30 Mar 2019 22:27:58 +0800 [thread overview]
Message-ID: <53f58a4f89ff911d0f761f4e9403e0ddb4454674.1553954776.git.ttjtftx@gmail.com> (raw)
In-Reply-To: <cover.1553954776.git.ttjtftx@gmail.com>
Signed-off-by: Jonathan Chang <ttjtftx@gmail.com>
---
t/t0000-basic.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 49923c5ff1..0cb69a89de 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -51,7 +51,7 @@ test_expect_success 'verify that the running shell supports "local"' '
test_expect_success '.git/objects should be empty after git init in an empty repo' '
find .git/objects -type f -print >should-be-empty &&
- test_line_count = 0 should-be-empty
+ test_must_be_empty should-be-empty
'
# also it should have 2 subdirectories; no fan-out anymore, pack, and info.
@@ -1110,7 +1110,7 @@ test_expect_success 'git update-index --refresh should succeed' '
test_expect_success 'no diff after checkout and git update-index --refresh' '
git diff-files >current &&
- cmp -s current /dev/null
+ test_must_be_empty current
'
################################################################
--
2.21.0
prev parent reply other threads:[~2019-03-30 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 14:27 [GSoC][PATCH v4 0/5] Avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 1/5] t0000: fix indentation Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 2/5] t0000: avoid using pipes Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l Jonathan Chang
2019-03-30 14:27 ` [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin Jonathan Chang
2019-03-30 19:38 ` Thomas Gummerer
2019-03-31 5:17 ` jonathan chang
2019-03-31 18:57 ` Thomas Gummerer
2019-03-30 14:27 ` Jonathan Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f58a4f89ff911d0f761f4e9403e0ddb4454674.1553954776.git.ttjtftx@gmail.com \
--to=ttjtftx@gmail.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).