git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Beat Bolli <bbolli@ewanet.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] pretty: Provide a strict ISO8601 date format
Date: Fri, 29 Aug 2014 23:02:36 +0200	[thread overview]
Message-ID: <5400EA6C.3030504@ewanet.ch> (raw)
In-Reply-To: <xmqqwq9r5dhb.fsf@gitster.dls.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

On 29.08.14 20:59, Junio C Hamano wrote:
>> +# ISO strict date format
>> +test_expect_success 'ISO and ISO-strict date formats display the same values' '
>> +	git log --format=%ai%n%ci | sed -e "s/ /T/; s/ //; s/..\$/:&/" >expected &&
>> +	git log --format=%aI%n%cI >actual &&
>> +	test_cmp expected actual
>> +'
> 
> This is saying that as long as --date=iso-strict format is
> bug-to-bug compatible with --date=iso format it is OK.
> 
> Which is fine, especially knowing the implementation ;-)
> 

Yeah, I wasn't sure how to test this, since the commit dates change with
each test run. Maybe it's the easy way out, but on the other hand it's
better than no test at all. Check the known parts with a regex?

Thanks,
Beat
-- 
mail: echo '<bNbolOli@ewaSPnetAM.ch>' | tr -d '[A-S]'
pgp: 0x506A903A; 49D5 794A EA77 F907 764F  D89E 304B 93CF 506A 903A
gsm: 4.7.7.6.0.7.7.9.7.1.4.e164.arpa
icbm: 47.0452 N, 7.2715 E

"It takes love over gold, and mind over matter" -- Dire Straits


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2014-08-29 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 16:58 [PATCH v2] pretty: Provide a strict ISO8601 date format Beat Bolli
2014-08-29 18:59 ` Junio C Hamano
2014-08-29 19:04   ` Junio C Hamano
2014-08-29 19:34     ` Andreas Schwab
2014-08-29 21:30     ` Beat Bolli
2014-08-29 21:02   ` Beat Bolli [this message]
2014-08-29 22:12     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5400EA6C.3030504@ewanet.ch \
    --to=bbolli@ewanet.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).