From: Johannes Sixt <j6t@kdbg.org>
To: David Aguilar <davvid@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Christian Couder" <chriscool@tuxfamily.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jon Seymour" <jon.seymour@gmail.com>
Subject: Re: [PATCH 1/2] bisect: remove unnecessary redirection
Date: Sat, 30 Aug 2014 22:57:05 +0200 [thread overview]
Message-ID: <54023AA1.40709@kdbg.org> (raw)
In-Reply-To: <1409427029-65886-1-git-send-email-davvid@gmail.com>
Am 30.08.2014 21:30, schrieb David Aguilar:
> `git rev-parse` is being called with --quiet so there's no need to
> redirect to /dev/null.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> git-bisect.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-bisect.sh b/git-bisect.sh
> index 1e0d602..c1c2321 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -365,7 +365,7 @@ bisect_reset() {
> }
> case "$#" in
> 0) branch=$(cat "$GIT_DIR/BISECT_START") ;;
> - 1) git rev-parse --quiet --verify "$1^{commit}" >/dev/null || {
> + 1) git rev-parse --quiet --verify "$1^{commit}" || {
This is wrong. The redirection quells stdout, but --quiet is about stderr.
> invalid="$1"
> die "$(eval_gettext "'\$invalid' is not a valid commit")"
> }
>
-- Hannes
prev parent reply other threads:[~2014-08-30 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 19:30 [PATCH 1/2] bisect: remove unnecessary redirection David Aguilar
2014-08-30 19:30 ` [PATCH 2/2] stash: prefer --quiet over shell redirection David Aguilar
2014-08-30 21:07 ` Johannes Sixt
2014-08-31 7:35 ` David Aguilar
2014-08-30 20:57 ` Johannes Sixt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54023AA1.40709@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).