git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ydirson@free.fr
To: git <git@vger.kernel.org>
Subject: [BUG] diff algorithm selection issue
Date: Tue, 26 May 2020 11:36:57 +0200 (CEST)	[thread overview]
Message-ID: <540830445.1034524732.1590485817611.JavaMail.root@zimbra39-e7> (raw)
In-Reply-To: <408624876.1034463388.1590484997966.JavaMail.root@zimbra39-e7>

Hi all,

When the config has diff.algorithm=patience set, "git diff --minimal" seems to
be ignored, and does not give the same output as "git diff --diff-algorithm=minimal",
but really the same as "git diff --diff-algorithm=patience".

See top commit on https://gitlab.com/ydirson/omaha/-/commits/bug/git-diff-minimal
where patience diff manages to show a quite braindead diff.

Also, I found it curious that in the manpage the long (--diff-algorithm=minimal) and
short (--minimal) forms are described with a copy-paste of the text, and no mention
of them being equivalent (or not, for that matter ;).

       reply	other threads:[~2020-05-26  9:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <408624876.1034463388.1590484997966.JavaMail.root@zimbra39-e7>
2020-05-26  9:36 ` ydirson [this message]
2020-05-26 16:10   ` [BUG] diff algorithm selection issue Junio C Hamano
2020-05-26 16:23     ` Junio C Hamano
2020-05-26 16:56       ` ydirson
2020-05-26 17:21         ` ydirson
2020-05-26 18:33           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540830445.1034524732.1590485817611.JavaMail.root@zimbra39-e7 \
    --to=ydirson@free.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).