From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] strbuf: export strbuf_addchars()
Date: Mon, 08 Sep 2014 23:36:11 +0200 [thread overview]
Message-ID: <540E214B.3060400@web.de> (raw)
In-Reply-To: <xmqqvboym09h.fsf@gitster.dls.corp.google.com>
Am 08.09.2014 um 20:32 schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> Move strbuf_addchars() to strbuf.c, where it belongs, and make it
>> available for other callers.
>>
>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>
> Wow, fixing up v1.7.0.2~9^2~2?
About time, isn't it? ;)
> Both patches look correct, but I have to wonder where you are
> drawing these clean-up opportunities from? Almost as if reading
> through dormant part of the codebase one of your hobbies or
> something ;-)
That, and I'm sitting on a pile of cleanup patches that grew whenever I
looked at some piece of code for the first time, e.g. due to bug
reports, or when I took a static analyzer for a test drive etc. I'm
trying to filter out the good ones and to send them at opportune moments
in order to avoid conflicts with real changes.
René
prev parent reply other threads:[~2014-09-08 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 7:03 [PATCH 1/2] strbuf: export strbuf_addchars() René Scharfe
2014-09-07 7:06 ` [PATCH 2/2] strbuf: use strbuf_addchars() for adding a char multiple times René Scharfe
2014-09-08 18:32 ` [PATCH 1/2] strbuf: export strbuf_addchars() Junio C Hamano
2014-09-08 21:36 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E214B.3060400@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).