git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Fredrik Gustafsson <iveqy@iveqy.com>, Cole <cole.minnaar@gmail.com>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] submodule: add ability to shallowly clone any branch in a submodule
Date: Sat, 13 Sep 2014 13:11:11 +0200	[thread overview]
Message-ID: <5414264F.1000909@web.de> (raw)
In-Reply-To: <20140912052123.GN10182@paksenarrion.iveqy.com>

Am 12.09.2014 um 07:21 schrieb Fredrik Gustafsson:
> On Thu, Sep 11, 2014 at 10:33:51PM +0200, Cole wrote:
>> Also if there is anything else you are currently looking at regarding
>> submodules or thinking about, I would be glad to hear about it or to try
>> look at it while I am working on these changes. Or if there is anything
>> you can think of for me to check with regards to these changes that
>> would also be appreciated.
>
> When implementing the --depth argument for submodules, I would have
> prefered that the depth was set from the commit of the submodules
> refered from the superprojekt and not it's branch.

That would help recursive fetch too.

> However this can't be done, since you can only clone from refs and not
> from a commit. However there's nothing that stops us from allowing to
> clone from a commit (of course we need to make sure that that commit is
> in a tree with a ref as leaf).
>
> I see this as a natural next step for the --depth function and something
> needed for it to be really useful. I'm actually suprised that people
> successfully uses the --depth function already since you always need to
> know how deep down the commit is.

I suspect this only works because users set the depth high enough or the
submodule is updated frequently to the tip of a branch.

  reply	other threads:[~2014-09-13 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11 17:11 [PATCH/RFC] submodule: add ability to shallowly clone any branch in a submodule Cole Minnaar
2014-09-11 19:21 ` Jens Lehmann
2014-09-11 20:33   ` Cole
2014-09-12  5:21     ` Fredrik Gustafsson
2014-09-13 11:11       ` Jens Lehmann [this message]
2014-09-13 11:21     ` Jens Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5414264F.1000909@web.de \
    --to=jens.lehmann@web.de \
    --cc=cole.minnaar@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=iveqy@iveqy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).