From: "Torsten Bögershausen" <tboegi@web.de>
To: Johan Herland <johan@herland.net>, git@vger.kernel.org
Cc: jhf@trifork.com
Subject: Re: [RFC/PATCH] notes: Allow adding empty notes with -C
Date: Sun, 21 Sep 2014 10:53:23 +0200 [thread overview]
Message-ID: <541E9203.9040702@web.de> (raw)
In-Reply-To: <1411268449-14636-1-git-send-email-johan@herland.net>
On 2014-09-21 05.00, Johan Herland wrote:
[]
> diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
> index cfd67ff..a6c399b 100755
> --- a/t/t3301-notes.sh
> +++ b/t/t3301-notes.sh
> @@ -1239,4 +1239,23 @@ test_expect_success 'git notes get-ref (--ref)' '
> test "$(GIT_NOTES_REF=refs/notes/bar git notes --ref=baz get-ref)" = "refs/notes/baz"
> '
>
> +cat > expect << EOF
Git style for shell scripts: Plase put no space between < or > or >> and the file name:
cat >expect <<EOF
> +commit 085b0d1309902c3148feb5a136515bdb9a1cd614
> +Author: A U Thor <author@example.com>
> +Date: Thu Apr 7 15:28:13 2005 -0700
> +
> + 16th
> +
> +Notes (foo):
> +EOF
> +
> +test_expect_success 'can create empty note with "git notes add -C $empty_blob"' '
> + test_commit 16th &&
> + blob=e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 &&
> + git notes add -C $blob &&
> + git log -1 > actual &&
git log -1 >actual &&
> + test_cmp expect actual &&
> + test "$(git notes list HEAD)" = "$blob"
> +'
> +
> test_done
>
next prev parent reply other threads:[~2014-09-21 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 19:47 Bug/request: the empty string should be a valid git note James H. Fisher
2014-09-20 21:50 ` James H. Fisher
2014-09-21 1:44 ` Johan Herland
2014-09-21 3:00 ` [RFC/PATCH] notes: Allow adding empty notes with -C Johan Herland
2014-09-21 8:53 ` Torsten Bögershausen [this message]
2014-09-21 9:46 ` Johan Herland
2014-09-21 23:32 ` Bug/request: the empty string should be a valid git note Kyle J. McKay
2014-09-22 17:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541E9203.9040702@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=jhf@trifork.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).