From: "René Scharfe" <l.s.r@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Vicent Marti <tanoku@gmail.com>
Subject: Re: [PATCH 2/2] use REALLOC_ARRAY for changing the allocation size of arrays
Date: Wed, 24 Sep 2014 21:27:25 +0200 [thread overview]
Message-ID: <54231B1D.7070807@web.de> (raw)
In-Reply-To: <20140924184740.GK1175@google.com>
Am 24.09.2014 um 20:47 schrieb Jonathan Nieder:
> René Scharfe wrote:
>
>> --- a/khash.h
>> +++ b/khash.h
>
> (not really about this patch) Where did this file come from? Do we
> want to be able to sync with upstream to get later bugfixes (e.g.,
> https://github.com/attractivechaos/klib/commit/000f0890)? If so, it
> might make sense to avoid unnecessary changes to the file so it's
> easier to see when it's safe to replace the file wholesale with a new
> version.
True. For this patch we're safe, I think, because it already called
xrealloc before I touched it (and has been doing that since it was
imported into git).
René
next prev parent reply other threads:[~2014-09-24 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 16:55 [PATCH 1/2] add macro REALLOCARRAY René Scharfe
2014-09-14 16:57 ` [PATCH 2/2] use REALLOCARRAY for changing the allocation size of arrays René Scharfe
2014-09-15 18:24 ` [PATCH 1/2] add macro REALLOCARRAY Junio C Hamano
2014-09-17 8:17 ` Jeff King
2014-09-16 3:04 ` Junio C Hamano
2014-09-16 18:52 ` René Scharfe
2014-09-16 18:56 ` [PATCH 1/2] add macro REALLOC_ARRAY René Scharfe
2014-09-24 7:32 ` Michael Haggerty
2014-09-24 17:59 ` Junio C Hamano
2014-09-24 19:27 ` René Scharfe
2014-09-16 18:56 ` [PATCH 2/2] use REALLOC_ARRAY for changing the allocation size of arrays René Scharfe
2014-09-24 18:47 ` Jonathan Nieder
2014-09-24 19:27 ` René Scharfe [this message]
2014-09-16 19:27 ` [PATCH 1/2] add macro REALLOCARRAY Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54231B1D.7070807@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=tanoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).