From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Marat Radchenko <marat@slonopotamus.org>,
msysGit <msysgit@googlegroups.com>,
git@vger.kernel.org
Subject: Re: [PATCH v4] MinGW(-W64) compilation
Date: Tue, 07 Oct 2014 21:57:45 +0200 [thread overview]
Message-ID: <543445B9.508@kdbg.org> (raw)
In-Reply-To: <xmqqvbnvemak.fsf@gitster.dls.corp.google.com>
Am 07.10.2014 um 21:01 schrieb Junio C Hamano:
> Johannes Sixt <j6t@kdbg.org> writes:
>
>> Am 06.10.2014 um 07:17 schrieb Marat Radchenko:
>>> On Tue, Sep 30, 2014 at 11:02:29AM +0400, Marat Radchenko wrote:
>>>> This patch series fixes building on modern MinGW and MinGW-W64 (including x86_64!).
>>>
>>> Junio, ping?
>>>
>>
>> Sorry, I forgot to report that this updated series works now for me.
>>
>> The patches all look reasonable. I don't have an opinion on the
>> restriction that MSVC < 2010 can't be used anymore (path 08/14).
>
> So, is that an Ack, or would you prefer to cook this first in
> msysgit tree and then feed the result as part of "This series is to
> shrink the difference between the mainline and msysgit" later?
At this time, it's really just a "works for me" report, because I didn't
look carefully at each patch. I may do that at some time later.
If someone from the msysgit crew (I don't count myself to it) could
report "works for us, too", then the series could go into your tree
right away, in my opinion.
-- Hannes
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2014-10-07 19:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 7:02 [PATCH v4] MinGW(-W64) compilation Marat Radchenko
2014-09-30 7:02 ` [PATCH 01/14] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64 Marat Radchenko
2014-09-30 7:02 ` [PATCH 02/14] MSVC: config.mak.uname: drop -D__USE_MINGW_ACCESS from CFLAGS Marat Radchenko
2014-09-30 7:02 ` [PATCH 03/14] MINGW: compat/mingw.h: drop fork() definition Marat Radchenko
2014-09-30 7:02 ` [PATCH 04/14] MINGW: do not fail at redefining pid_t on MinGW-W64 Marat Radchenko
2014-09-30 7:02 ` [PATCH 05/14] MINGW: config.mak.uname: allow using cURL for non-msysGit builds Marat Radchenko
2014-09-30 7:02 ` [PATCH 06/14] MINGW: compat/winansi.c: do not redefine CONSOLE_FONT_INFOEX Marat Radchenko
2014-09-30 7:02 ` [PATCH 07/14] Fix BASIC_LDFLAGS and COMPAT_CFLAGS for 64bit MinGW-w64 Marat Radchenko
2014-09-30 7:02 ` [PATCH 08/14] MINGW: git-compat-util.h: use inttypes.h for printf macros Marat Radchenko
2014-09-30 7:02 ` [PATCH 09/14] MINGW: config.mak.uname: reorganize MinGW settings Marat Radchenko
2014-09-30 7:02 ` [PATCH 10/14] Makefile: introduce CROSS_COMPILE variable Marat Radchenko
2014-09-30 7:02 ` [PATCH 11/14] compat/nedmalloc/malloc.c.h: fix compilation under MinGW-W64 Marat Radchenko
2014-09-30 7:02 ` [PATCH 12/14] Fix pointer -> integer casts on IL32P64 systems Marat Radchenko
2014-09-30 7:02 ` [PATCH 13/14] git-compat-util.h: fix integer overflow " Marat Radchenko
2014-09-30 7:02 ` [PATCH 14/14] MINGW: config.mak.uname: auto-detect MinGW build from compiler Marat Radchenko
2014-09-30 10:10 ` [PATCH v4] MinGW(-W64) compilation Duy Nguyen
2014-10-06 5:17 ` Marat Radchenko
2014-10-06 18:50 ` Johannes Sixt
2014-10-07 19:01 ` Junio C Hamano
2014-10-07 19:57 ` Johannes Sixt [this message]
2014-10-07 23:09 ` Thomas Braun
2014-10-08 4:53 ` Marat Radchenko
2014-10-08 8:59 ` Johannes Schindelin
2014-10-08 9:32 ` Marat Radchenko
2014-10-08 10:52 ` Johannes Schindelin
2014-10-08 10:43 ` Thomas Braun
2014-10-08 9:35 ` Johannes Schindelin
2014-10-08 9:40 ` Johannes Schindelin
2014-10-08 10:59 ` Marat Radchenko
2014-10-08 13:58 ` [msysGit] " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543445B9.508@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marat@slonopotamus.org \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).