From: "Jakub Narębski" <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] Allow building Git with Asciidoctor
Date: Tue, 14 Oct 2014 12:07:51 +0200 [thread overview]
Message-ID: <543CF5F7.5060704@gmail.com> (raw)
In-Reply-To: <20141014003451.GA7041@vauxhall.crustytoothpaste.net>
brian m. carlson wrote:
> On Mon, Oct 13, 2014 at 01:41:31PM -0700, Junio C Hamano wrote:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>>
>>> The second two patches implement some basic support for building with
>>> Asciidoctor. The first of these moves some items into variables due to
>>> some differences between the AsciiDoc and Asciidoctor command lines.
>>> The user can then override these values when invoking make.
>>>
>>> The final patch adds support for the linkgit macro. Asciidoctor uses
>>> Ruby extensions to implement macro support, unlike AsciiDoc, which uses
>>> a configuration file.
>>
>> What I do not understand is that 3/4 lets you drop inclusion of
>> asciidoc.conf which contains a lot more than just linkgit:
>> definition.
>
> Asciidoctor just doesn't understand the -f argument, so trying to pass
> it is going to fail. For Asciidoctor, you're going to want to do
> something like "-I. -rasciidoctor/extensions -rextensions" there
> instead.
>
> As for the rest of the asciidoc.conf file, the DocBook manpage header
> declarations are implemented automatically by Asciidoctor after my
> recent patches. The paragraph hacks do not appear to be necessary with
> Asciidoctor, so they've been omitted.
>
> That leaves the attributes. All but litdd are built-in to Asciidoctor,
> and I can reroll with a modification to extensions.rb that implements
> that one.
Would it be possible to automatically convert asciidoc.conf file to
Asciidoctor extension?
--
Jakub Narębski
next prev parent reply other threads:[~2014-10-14 10:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 23:37 [PATCH 0/4] Allow building Git with Asciidoctor brian m. carlson
2014-10-11 23:37 ` [PATCH 1/4] Documentation: adjust document title underlining brian m. carlson
2014-10-13 20:35 ` Junio C Hamano
2014-10-11 23:37 ` [PATCH 2/4] Documentation: fix mismatched delimiters in git-imap-send brian m. carlson
2014-10-11 23:37 ` [PATCH 3/4] Documentation: move some AsciiDoc parameters into variables brian m. carlson
2014-10-15 20:43 ` Junio C Hamano
2014-10-16 1:52 ` brian m. carlson
2014-10-11 23:37 ` [PATCH 4/4] Documentation: implement linkgit macro for Asciidoctor brian m. carlson
2014-10-13 20:41 ` [PATCH 0/4] Allow building Git with Asciidoctor Junio C Hamano
2014-10-14 0:34 ` brian m. carlson
2014-10-14 10:07 ` Jakub Narębski [this message]
2014-10-14 11:26 ` brian m. carlson
2014-10-14 9:51 ` Jeff King
2014-10-14 17:08 ` Junio C Hamano
2014-10-15 1:17 ` brian m. carlson
2014-10-15 17:43 ` Junio C Hamano
2014-10-15 11:24 ` Thomas Braun
2014-10-15 23:52 ` brian m. carlson
2014-10-16 22:53 ` Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543CF5F7.5060704@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).