From: Victoria Dye <vdye@github.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: peff@peff.net, gitster@pobox.com,
Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH 0/3] Bundle URIs 4.5: fixups from part IV
Date: Mon, 12 Dec 2022 10:07:26 -0800 [thread overview]
Message-ID: <543a72cd-a488-d535-f6fe-4b70c5f8d333@github.com> (raw)
In-Reply-To: <pull.1443.git.1670866407.gitgitgadget@gmail.com>
Derrick Stolee via GitGitGadget wrote:
> These patches represent small fixups that came in review from the last
> version of 'ds/bundle-uri-4'. Since it was merged to 'next', these patches
> are forward-fixes on that branch.
>
> Note: I did not include any changes that could be solved by adding an UNUSED
> macro, saving that for Peff and his already-prepared patches in that area.
>
> Thanks, -Stolee
>
> Derrick Stolee (3):
> bundle-uri: drop unused 'uri' parameter
> bundle-uri: advertise based on repo config
> bundle-uri: remove GIT_TEST_BUNDLE_URI env variable
The first two patches (unused arg removal & using repo to get config) are
straightforward fixes for issues mentioned earlier ([1] and [2],
respectively). The last patch replaces the 'GIT_TEST_BUNDLE_URI' environment
variable with globally setting 'transfer.bundleURI' for a subset of the
'lib-bundle-uri-protocol.sh' tests. The comment you added in that file ("The
remaining tests will all assume transfer.bundleURI=true") clearly explains
what you're doing there as a reference for future updates to the tests.
These patches all look good to me. Thanks!
[1] https://lore.kernel.org/git/affbc458-d4f5-525f-d431-5ec1d489afc8@github.com/
[2] https://lore.kernel.org/git/4d4e02c3-89dc-8372-7e8a-7ec76fdd6f4e@github.com/
next prev parent reply other threads:[~2022-12-12 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 17:33 [PATCH 0/3] Bundle URIs 4.5: fixups from part IV Derrick Stolee via GitGitGadget
2022-12-12 17:33 ` [PATCH 1/3] bundle-uri: drop unused 'uri' parameter Derrick Stolee via GitGitGadget
2022-12-19 10:57 ` Ævar Arnfjörð Bjarmason
2022-12-20 0:49 ` Junio C Hamano
2022-12-20 14:02 ` Derrick Stolee
2022-12-20 20:50 ` Ævar Arnfjörð Bjarmason
2022-12-20 13:57 ` Derrick Stolee
2022-12-20 20:46 ` Ævar Arnfjörð Bjarmason
2022-12-12 17:33 ` [PATCH 2/3] bundle-uri: advertise based on repo config Derrick Stolee via GitGitGadget
2022-12-19 11:04 ` Ævar Arnfjörð Bjarmason
2022-12-20 13:54 ` Derrick Stolee
2022-12-12 17:33 ` [PATCH 3/3] bundle-uri: remove GIT_TEST_BUNDLE_URI env variable Derrick Stolee via GitGitGadget
2022-12-19 11:09 ` Ævar Arnfjörð Bjarmason
2022-12-20 13:51 ` Derrick Stolee
2022-12-20 20:41 ` Ævar Arnfjörð Bjarmason
2022-12-12 18:07 ` Victoria Dye [this message]
2022-12-12 20:59 ` [PATCH 0/3] Bundle URIs 4.5: fixups from part IV Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543a72cd-a488-d535-f6fe-4b70c5f8d333@github.com \
--to=vdye@github.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).