git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] use child_process_init() to initialize struct child_process variables
Date: Tue, 28 Oct 2014 21:52:34 +0100	[thread overview]
Message-ID: <54500212.7040603@web.de> (raw)

Call child_process_init() instead of zeroing the memory of variables of
type struct child_process by hand before use because the former is both
clearer and shorter.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 bundle.c           | 2 +-
 column.c           | 2 +-
 trailer.c          | 2 +-
 transport-helper.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bundle.c b/bundle.c
index fa67057..c846092 100644
--- a/bundle.c
+++ b/bundle.c
@@ -381,7 +381,7 @@ int create_bundle(struct bundle_header *header, const char *path,
 	write_or_die(bundle_fd, "\n", 1);
 
 	/* write pack */
-	memset(&rls, 0, sizeof(rls));
+	child_process_init(&rls);
 	argv_array_pushl(&rls.args,
 			 "pack-objects", "--all-progress-implied",
 			 "--stdout", "--thin", "--delta-base-offset",
diff --git a/column.c b/column.c
index 8082a94..786abe6 100644
--- a/column.c
+++ b/column.c
@@ -374,7 +374,7 @@ int run_column_filter(int colopts, const struct column_options *opts)
 	if (fd_out != -1)
 		return -1;
 
-	memset(&column_process, 0, sizeof(column_process));
+	child_process_init(&column_process);
 	argv = &column_process.args;
 
 	argv_array_push(argv, "column");
diff --git a/trailer.c b/trailer.c
index 8514566..7ff036c 100644
--- a/trailer.c
+++ b/trailer.c
@@ -237,7 +237,7 @@ static const char *apply_command(const char *command, const char *arg)
 		strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);
 
 	argv[0] = cmd.buf;
-	memset(&cp, 0, sizeof(cp));
+	child_process_init(&cp);
 	cp.argv = argv;
 	cp.env = local_repo_env;
 	cp.no_stdin = 1;
diff --git a/transport-helper.c b/transport-helper.c
index 6cd9dd1..0224687 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -414,7 +414,7 @@ static int get_exporter(struct transport *transport,
 	struct child_process *helper = get_helper(transport);
 	int i;
 
-	memset(fastexport, 0, sizeof(*fastexport));
+	child_process_init(fastexport);
 
 	/* we need to duplicate helper->in because we want to use it after
 	 * fastexport is done with it. */
-- 
2.1.2

             reply	other threads:[~2014-10-28 20:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 20:52 René Scharfe [this message]
2014-10-28 21:58 ` [PATCH] use child_process_init() to initialize struct child_process variables mike.gorchak.qnx
2014-10-29 17:21 ` Jeff King
2014-10-29 19:16   ` Junio C Hamano
2014-10-30 18:07     ` Junio C Hamano
2014-10-30 21:25       ` Jeff King
2014-10-30 18:08     ` [PATCH] bundle: split out a helper function to compute and write prerequisites Junio C Hamano
2014-10-30 21:26       ` Jeff King
2014-10-30 21:35     ` [PATCH] use child_process_init() to initialize struct child_process variables Jeff King
2014-10-31  0:19       ` Philip Oakley
2014-10-31 21:48         ` Junio C Hamano
2014-11-01  3:33           ` Jeff King
2014-11-02 22:54             ` Philip Oakley
2014-11-03 18:26               ` Junio C Hamano
2014-11-03 22:04                 ` Jeff King
2014-11-03 23:42                   ` Junio C Hamano
2014-11-04 21:56                     ` Junio C Hamano
2014-11-04 23:32                       ` Jeff King
2014-11-05  0:32                         ` Junio C Hamano
2014-11-05 13:41                         ` Philip Oakley
2014-11-05 13:35                     ` Philip Oakley
2014-11-05 19:35                       ` Jeff King
2014-11-05 23:50                         ` Philip Oakley
2014-11-09 13:49   ` René Scharfe
2014-11-10  7:14     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54500212.7040603@web.de \
    --to=l.s.r@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).