From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: ockham@raz.or.at
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] sparse: suppress an "using sizeof on a function" warning
Date: Fri, 07 Nov 2014 13:50:27 +0000 [thread overview]
Message-ID: <545CCE23.5080507@ramsay1.demon.co.uk> (raw)
Commit d57da44b1 ("imap-send: use libcurl for implementation",
06-11-2014) updates the implementation of the imap-send command
to make use of libcurl's high(er)-level API functions.
In doing so, this introduces a sparse warning about "using sizeof
on a function". In order to suppress the warning, we use the same
solution used in commit 9371322a6 ("sparse: suppress some "using
sizeof on a function" warnings", 06-10-2013) which solved exactly
this problem for the other commands using libcurl.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Bernhard,
If you need to re-roll your 'br/imap-send-via-libcurl' branch, could
you please squash this into your patch.
Thanks!
ATB,
Ramsay Jones
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 1ded274..0fc2790 100644
--- a/Makefile
+++ b/Makefile
@@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX
gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \
-DGIT_LOCALE_PATH='"$(localedir_SQ)"'
-http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \
+http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp: SPARSE_FLAGS += \
-DCURL_DISABLE_TYPECHECK
ifdef NO_EXPAT
--
2.1.0
next reply other threads:[~2014-11-07 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 13:50 Ramsay Jones [this message]
2014-11-07 20:01 ` [PATCH] sparse: suppress an "using sizeof on a function" warning ockham
2014-11-07 20:08 ` Junio C Hamano
2014-11-07 21:07 ` ockham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CCE23.5080507@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ockham@raz.or.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).