From: Paolo Bonzini <bonzini@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] git-am: add --message-id/--no-message-id
Date: Wed, 26 Nov 2014 08:06:14 +0100 [thread overview]
Message-ID: <54757BE6.2070103@gnu.org> (raw)
In-Reply-To: <xmqqbnnusvmd.fsf@gitster.dls.corp.google.com>
On 26/11/2014 00:34, Junio C Hamano wrote:
> ... makes the result look questionable. The variable is initialized
> to empty; when it is written out to $dotest/messageid and later read
> back here, that empty value is not covered by this case statement.
>
> Perhaps clearing messageid= upon seeing "--no-message-id" and using
> "'t' or empty" makes the code a bit easier to follow? I dunno.
Possibly. The other side is that it would be handled differently than
scissors and keep. Changing everything is possible but would break
continuing a "git am" operation across an update, so I chose consistency.
Paolo
next prev parent reply other threads:[~2014-11-26 7:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 14:00 [PATCH 0/2] git-am: add --message-id/--no-message-id options Paolo Bonzini
2014-11-25 14:00 ` [PATCH 1/2] git-mailinfo: add --message-id Paolo Bonzini
2014-11-25 14:00 ` [PATCH 2/2] git-am: add --message-id/--no-message-id Paolo Bonzini
2014-11-25 23:34 ` Junio C Hamano
2014-11-26 7:06 ` Paolo Bonzini [this message]
2014-11-25 16:27 ` [PATCH 0/2] git-am: add --message-id/--no-message-id options Christian Couder
2014-11-25 17:01 ` Paolo Bonzini
2014-11-25 21:21 ` Christian Couder
2014-11-26 9:07 ` Paolo Bonzini
2014-11-27 0:23 ` Christian Couder
2014-11-25 18:33 ` Junio C Hamano
2014-11-25 19:16 ` Paolo Bonzini
2014-11-25 20:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54757BE6.2070103@gnu.org \
--to=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).