From: "Torsten Bögershausen" <tboegi@web.de>
To: David Michael <fedora.dm0@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] compat: convert modes to use portable file type values
Date: Sun, 30 Nov 2014 21:16:39 +0100 [thread overview]
Message-ID: <547B7B27.90204@web.de> (raw)
In-Reply-To: <87vblxl8ah.fsf@gmail.com>
On 2014-11-30 03.41, David Michael wrote:
Some minor comments:
> +static inline mode_t mode_native_to_git(mode_t native_mode)
> +{
> + if (S_ISREG(native_mode))
> + return 0100000 | (native_mode & 07777);
> + else if (S_ISDIR(native_mode))
> + return 0040000 | (native_mode & 07777);
> + else if (S_ISLNK(native_mode))
> + return 0120000 | (native_mode & 07777);
> + else if (S_ISBLK(native_mode))
> + return 0060000 | (native_mode & 07777);
> + else if (S_ISCHR(native_mode))
> + return 0020000 | (native_mode & 07777);
> + else if (S_ISFIFO(native_mode))
> + return 0010000 | (native_mode & 07777);
> + else /* Non-standard type bits were given. */
> + return native_mode & 07777;
> +}
Could the code be more human-readable ?
static inline mode_t mode_native_to_git(mode_t native_mode)
{
int perm_bits = native_mode & 07777;
if (S_ISREG(native_mode))
return 0100000 | perm_bits;
if (S_ISDIR(native_mode))
return 0040000 | perm_bits;
if (S_ISLNK(native_mode))
return 0120000 | perm_bits;
if (S_ISBLK(native_mode))
return 0060000 | perm_bits;
if (S_ISCHR(native_mode))
return 0020000 | perm_bits;
if (S_ISFIFO(native_mode))
return 0010000 | perm_bits;
/* Non-standard type bits were given. */
/* Shouldn't we die() here ?? */
return perm_bits;
}
next prev parent reply other threads:[~2014-11-30 20:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 2:41 [PATCH] compat: convert modes to use portable file type values David Michael
2014-11-30 20:16 ` Torsten Bögershausen [this message]
2014-12-01 3:40 ` David Michael
2014-12-01 5:55 ` Torsten Bögershausen
2014-12-01 12:48 ` David Michael
2014-12-01 17:46 ` David Michael
2014-12-01 3:11 ` Junio C Hamano
2014-12-01 14:44 ` Duy Nguyen
2014-12-01 17:49 ` David Michael
2014-12-01 17:57 ` Junio C Hamano
2014-12-01 19:10 ` David Michael
2014-12-01 20:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547B7B27.90204@web.de \
--to=tboegi@web.de \
--cc=fedora.dm0@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).