git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: "Torsten Bögershausen" <tboegi@web.de>,
	"Christian Hesse" <mail@eworm.de>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/1] skip RFC1991 tests with gnupg 2.1.x
Date: Thu, 11 Dec 2014 17:54:56 +0100	[thread overview]
Message-ID: <5489CC60.7080704@drmicha.warpmail.net> (raw)
In-Reply-To: <5489B90B.6070706@web.de>

Torsten Bögershausen schrieb am 11.12.2014 um 16:32:
> On 11.12.14 10:30, Christian Hesse wrote:
>> ---
>>  t/lib-gpg.sh   |  6 ++++++
>>  t/t7004-tag.sh | 14 +++++++-------
>>  2 files changed, 13 insertions(+), 7 deletions(-)
>>
>> diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
>> index cd2baef..05b07c6 100755
>> --- a/t/lib-gpg.sh
>> +++ b/t/lib-gpg.sh
>> @@ -22,6 +22,12 @@ else
>>  		GNUPGHOME="$(pwd)/gpghome"
>>  		export GNUPGHOME
>>  		test_set_prereq GPG
>> +		case "$gpg_version" in
>> +		'gpg (GnuPG) 2.1.'*)
>> +			say "Your version of gpg (2.1.x) is missing some legacy features"
>> +			test_set_prereq GNUPG21
>> +			;;
>> +		esac
>>  		;;
>>  	esac
>>  fi
> We do not really need the GNUPG21 (and we don't need to touch the TC at all)
> 		case "$gpg_version" in
> 		'gpg (GnuPG) 2.1.'*)
> 			say "Your version of gpg (2.1.x) is missing some legacy features"
> 			;;
> 		*)
> 			test_set_prereq GPG
> 			;;
> 
> 		esac
>   		;;
> 

That would disable all GPG tests, which is pretty harsh.

If gpg 2.1 is the future of gpg (which I don't know), which should
rather prepare for that and make our tests independent of the version.
Is gpg 2.1 stable enough to cater for its special needs?

Michael

  reply	other threads:[~2014-12-11 16:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11  9:30 [PATCH 1/1] skip RFC1991 tests with gnupg 2.1.x Christian Hesse
2014-12-11 15:32 ` Torsten Bögershausen
2014-12-11 16:54   ` Michael J Gruber [this message]
2014-12-11 22:44     ` Christian Hesse
2014-12-11 23:10       ` Junio C Hamano
2014-12-12  8:35         ` Christian Hesse
2014-12-12  9:54           ` Christian Hesse
2014-12-12 16:00             ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5489CC60.7080704@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=mail@eworm.de \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).