From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "GitList" <git@vger.kernel.org>,
"W. Trevor King" <wking@tremily.us>,
"David Aguilar" <davvid@gmail.com>
Subject: Re: [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic
Date: Wed, 3 Apr 2013 23:24:57 +0100 [thread overview]
Message-ID: <548AC0AF83DA42EA8C39C268693606AD@PhilipOakley> (raw)
In-Reply-To: 7vhajo76xh.fsf@alter.siamese.dyndns.org
Sent: Wednesday, April 03, 2013 2:13 AM
> Junio C Hamano <gitster@pobox.com> writes:
>
>> You are creating a gap in the output so that you can add some more
>> stuff in later patches, which is fine, but I do not think we call
>> that kind of change a "refactor" ;-).
>>
>> The change looks fine.
>
> I'll queue what I suggested on 'pu' for now.
It looks good. I'm happy with your suggestions as queued.
Acked-by: Philip Oakley <philipoakley@iee.org>
Longer term I'd like to be able to show all the guides as a double -gg
option, but this is a great start.
>
> Thanks.
>
>
> -----
next prev parent reply other threads:[~2013-04-03 22:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 22:39 [PATCH V3 0/5] Git help option to list user guides Philip Oakley
2013-04-02 22:39 ` [PATCH V3 1/5] Show help: -a and -g option, and 'git help <concept>' usage Philip Oakley
2013-04-02 23:15 ` Junio C Hamano
2013-04-02 22:39 ` [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic Philip Oakley
2013-04-02 23:15 ` Junio C Hamano
2013-04-03 1:13 ` Junio C Hamano
2013-04-03 22:24 ` Philip Oakley [this message]
2013-04-02 22:39 ` [PATCH V3 3/5] Help.c add --guide option Philip Oakley
2013-04-02 22:39 ` [PATCH V3 4/5] Help.c: add list_common_guides_help() function Philip Oakley
2013-04-02 23:10 ` Junio C Hamano
2013-04-03 2:30 ` Eric Sunshine
2013-04-12 13:51 ` [PATCH] help: mark common_guides[] as translatable Simon Ruderich
2013-04-12 16:16 ` Philip Oakley
2013-04-02 22:39 ` [PATCH V3 5/5] Help doc: Include --guide option description Philip Oakley
2013-04-02 23:11 ` Junio C Hamano
2013-04-03 2:28 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548AC0AF83DA42EA8C39C268693606AD@PhilipOakley \
--to=philipoakley@iee.org \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox