Re: [PATCH v2] git-config support for diff.relative setting

[kelson@shysecurity.com]

> "Philip Oakley" <philipoakley@iee.org> wrote:
> Shouldn't this `(identical to "git diff --relative")` also be
>included in the documentation change? It would truly clarify the
> intenbt for the reader.

Updated as follows:
+diff.relative::
+	Show pathnames relative to the current directory and exclude
+	changes outside this directory; equivalent to the 'git diff'
+	option '--relative'.

> "Junio C Hamano" <gitster@pobox.com> wrote:
> There should be a way to run non-relative diff in a repository that
> has the configuration set, perhaps by overriding with some command
> line option (e.g. "--no-relative").

Good idea; I'll put together a second patch for a "--no-relative" option 
to disable diff.relative.

-----Original Message-----
From: Junio C Hamano <gitster@pobox.com>
Sent: 12/20/2014 09:58 PM
To: Philip Oakley <philipoakley@iee.org>
CC: <kelson@shysecurity.com>,  "Git Mailing List" <git@vger.kernel.org>, 
  "Duy Nguyen" <pclouds@gmail.com>,  "Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v2] git-config support for diff.relative setting

"Philip Oakley" <philipoakley@iee.org> writes:
> From: <kelson@shysecurity.com>
>> By default, git-diff shows changes and pathnames relative to the
>> repository root. Setting the diff.relative config option to "true"
>> shows pathnames relative to the current directory and excludes
>> changes outside this directory (identical to "git diff --relative").
> Shouldn't this `(identical to "git diff --relative")` also be included
> in the documentation change? It would truly clarify the intenbt for
> the reader.

A configuration that sticks a non-default behaviour without a way to
revert to the default is a no-no.

There should be a way to run non-relative diff in a repository that
has the configuration set, perhaps by overriding with some command
line option (e.g. "--no-relative").