git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kelson@shysecurity.com
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>,
	Philip Oakley <philipoakley@iee.org>,
	Duy Nguyen <pclouds@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: [PATCH v3 1/2] git-config support for diff.relative setting
Date: Tue, 30 Dec 2014 12:56:20 -0500	[thread overview]
Message-ID: <54A2E744.8010508@shysecurity.com> (raw)
In-Reply-To: <54972C29.7060801@shysecurity.com>

By default, git-diff shows changes and pathnames relative to the 
repository root.
Setting diff.relative to "true" shows pathnames relative to the current 
directory
and excludes changes outside this directory.
---
  Documentation/diff-config.txt |  5 +++++
  diff.c                        |  8 ++++++++
  t/t4045-diff-relative.sh      | 21 +++++++++++++++++++++
  3 files changed, 34 insertions(+)

diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt
index b001779..496e9b0 100644
--- a/Documentation/diff-config.txt
+++ b/Documentation/diff-config.txt
@@ -103,6 +103,11 @@ diff.orderfile::
      one shell glob pattern per line.
      Can be overridden by the '-O' option to linkgit:git-diff[1].

+diff.relative::
+    Show pathnames relative to the current directory and exclude
+    changes outside this directory; equivalent to the 'git diff'
+    option '--relative'.
+
  diff.renameLimit::
      The number of files to consider when performing the copy/rename
      detection; equivalent to the 'git diff' option '-l'.
diff --git a/diff.c b/diff.c
index d1bd534..03697a9 100644
--- a/diff.c
+++ b/diff.c
@@ -223,6 +223,14 @@ int git_diff_ui_config(const char *var, const char 
*value, void *cb)
          return 0;
      }

+    if (!strcmp(var, "diff.relative")) {
+        if (git_config_bool(var, value))
+            DIFF_OPT_SET(&default_diff_options, RELATIVE_NAME);
+        else
+            DIFF_OPT_CLR(&default_diff_options, RELATIVE_NAME);
+        return 0;
+    }
+
      if (git_color_config(var, value, cb) < 0)
          return -1;

diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh
index 3950f50..8c8fe0b 100755
--- a/t/t4045-diff-relative.sh
+++ b/t/t4045-diff-relative.sh
@@ -29,6 +29,23 @@ test_expect_success "-p $*" "
  "
  }

+check_config() {
+expect=$1; shift
+cat >expected <<EOF
+diff --git a/$expect b/$expect
+new file mode 100644
+index 0000000..25c05ef
+--- /dev/null
++++ b/$expect
+@@ -0,0 +1 @@
++other content
+EOF
+test_expect_success "git-config diff.relative=true in $1" "
+    (cd $1; git -c diff.relative=true diff -p HEAD^ >../actual) &&
+    test_cmp expected actual
+"
+}
+
  check_numstat() {
  expect=$1; shift
  cat >expected <<EOF
@@ -69,5 +86,9 @@ for type in diff numstat stat raw; do
      check_$type file2 --relative=subdir
      check_$type dir/file2 --relative=sub
  done
+for type in config; do
+    check_$type file2 subdir/
+    check_$type file2 subdir
+done

  test_done
-- 
1.9.1

  reply	other threads:[~2014-12-30 17:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11  7:28 [PATCH] added git-config support for diff.relative setting Kelson
2014-12-11 13:37 ` Duy Nguyen
2014-12-11 21:41   ` Kelson
2014-12-12 23:25 ` [PATCH v2] " Kelson
2014-12-21 20:23   ` [PATCH v3 1/2] " kelson
2014-12-30 17:56     ` kelson [this message]
2014-12-30 18:16       ` Junio C Hamano
2014-12-30 19:32       ` [PATCH 1/2] support for --no-relative and diff.relative kelson
2015-01-06 16:19         ` kelson
2015-01-07 18:09           ` Junio C Hamano
2015-01-07 18:46             ` kelson
2015-01-07 20:26               ` Junio C Hamano
2015-01-07 19:02             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A2E744.8010508@shysecurity.com \
    --to=kelson@shysecurity.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=philipoakley@iee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).