From: "Torsten Bögershausen" <tboegi@web.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] move MAXDEPTH definition to the cache.h
Date: Tue, 20 Jan 2015 20:25:48 +0100 [thread overview]
Message-ID: <54BEABBC.9070302@web.de> (raw)
In-Reply-To: <1421777797-14781-1-git-send-email-kuleshovmail@gmail.com>
> --- a/cache.h
> +++ b/cache.h
> @@ -1010,6 +1010,7 @@ extern int read_ref(const char *refname, unsigned char *sha1);
> * Caps and underscores refers to the special refs, such as HEAD,
> * FETCH_HEAD and friends, that all live outside of the refs/ directory.
> */
What happened to the comment line ?
Should it go away or better stay ?
When we move the definition to a common file,
it is not 100% clear what MAXDEPTH is about,
and the comment is even more important, I think:
> +/* We allow "recursive" symbolic links. Only within reason, though. */
> +#define MAXDEPTH 5
On the other hand, if we find a better name for that definition,
we may skip the comment.
A first suggestion may be
#define MAXDEPTH_FOR_SYMLINKS 5
but other variants are possible.
next prev parent reply other threads:[~2015-01-20 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 18:16 [PATCH] move MAXDEPTH definition to the cache.h Alexander Kuleshov
2015-01-20 19:25 ` Torsten Bögershausen [this message]
2015-01-21 0:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BEABBC.9070302@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kuleshovmail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).