git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* git --recurse-submodule does not recurse to sub-submodules (etc.)
@ 2015-01-19 20:19 Maximilian Held
  2015-01-20 21:21 ` Jens Lehmann
  0 siblings, 1 reply; 3+ messages in thread
From: Maximilian Held @ 2015-01-19 20:19 UTC (permalink / raw)
  To: git

I have a directory with nested submodules, such as:

supermodule/submodule/sub-submodule/sub-sub-submodule

When I cd to supermodule and do:

"git push --recurse-submodule=check" (or on-demand),

git only pushes the submodule, but not the sub-submodule etc.

Maybe this is expected behavior and not a bug, but I thought it was
pretty unintuitive. I expected that git would push, well, recursively.

Best
Max

http://www.maxheld.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git --recurse-submodule does not recurse to sub-submodules (etc.)
  2015-01-19 20:19 git --recurse-submodule does not recurse to sub-submodules (etc.) Maximilian Held
@ 2015-01-20 21:21 ` Jens Lehmann
  2015-01-23 22:02   ` Maximilian Held
  0 siblings, 1 reply; 3+ messages in thread
From: Jens Lehmann @ 2015-01-20 21:21 UTC (permalink / raw)
  To: Maximilian Held, git; +Cc: Voigt, Heiko, Fredrik Gustafsson

Am 19.01.2015 um 21:19 schrieb Maximilian Held:
> I have a directory with nested submodules, such as:
>
> supermodule/submodule/sub-submodule/sub-sub-submodule
>
> When I cd to supermodule and do:
>
> "git push --recurse-submodule=check" (or on-demand),
>
> git only pushes the submodule, but not the sub-submodule etc.
>
> Maybe this is expected behavior and not a bug, but I thought it was
> pretty unintuitive. I expected that git would push, well, recursively.

I agree this is unexpected and should be fixed. I suspect the fix
would be to teach the push_submodule() function to use the same
flags that were used for the push in the superproject.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: git --recurse-submodule does not recurse to sub-submodules (etc.)
  2015-01-20 21:21 ` Jens Lehmann
@ 2015-01-23 22:02   ` Maximilian Held
  0 siblings, 0 replies; 3+ messages in thread
From: Maximilian Held @ 2015-01-23 22:02 UTC (permalink / raw)
  To: Jens Lehmann; +Cc: git, Voigt, Heiko, Fredrik Gustafsson

Thanks, Jens.

Incidentally,

git submodule update --init --recursive

Does exactly what expected – it updates sub/sub/submodules, so there
is certainly some inconsistency in how the --recursive flag is handled
here.
info@maxheld.de | http://www.maxheld.de | http://www.civicon.de |
Mobil: +49 151 22958775 | Skype: maximilian.held
Bremen International Graduate School of Social Sciences | Wiener
Straße / Celsiusstraße | 28359 Bremen | Germany


On Tue, Jan 20, 2015 at 10:21 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
> Am 19.01.2015 um 21:19 schrieb Maximilian Held:
>
>> I have a directory with nested submodules, such as:
>>
>> supermodule/submodule/sub-submodule/sub-sub-submodule
>>
>> When I cd to supermodule and do:
>>
>> "git push --recurse-submodule=check" (or on-demand),
>>
>> git only pushes the submodule, but not the sub-submodule etc.
>>
>> Maybe this is expected behavior and not a bug, but I thought it was
>> pretty unintuitive. I expected that git would push, well, recursively.
>
>
> I agree this is unexpected and should be fixed. I suspect the fix
> would be to teach the push_submodule() function to use the same
> flags that were used for the push in the superproject.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-23 22:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-19 20:19 git --recurse-submodule does not recurse to sub-submodules (etc.) Maximilian Held
2015-01-20 21:21 ` Jens Lehmann
2015-01-23 22:02   ` Maximilian Held

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).