From: "Rémi Rampin" <remirampin@gmail.com>
To: Chris Packham <judge.packham@gmail.com>,
Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: GIT <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Makes _do_open2 set _gitdir to actual path
Date: Tue, 03 Feb 2015 11:00:41 -0500 [thread overview]
Message-ID: <54D0F0A9.3080607@gmail.com> (raw)
In-Reply-To: <CAFOYHZB_c3U9jpAq=jrGgMU+wMMf8w5D9iqLC9ccGC8S3hhXZg@mail.gmail.com>
2015-02-02 12:24 UTC-05:00, Remi Rampin <remirampin@gmail.com>:
>> - return [_is_git [file join [file dirname $path] $link_target]]
>> + set link_target_abs [file join [file dirname $path] $link_target]
2015-02-03 3:51 UTC-05:00, Chris Packham <judge.packham@gmail.com>:
> At this point link_target_abs is something like
> sub/../.git/modules/sub. It might be nice to normalize this with 'git
> rev-parse --git-dir' or even just (cd $link_target_abs && pwd). I'm
> not sure if tcl has anything built in that could do this kind of
> normalization.
There is 'file normalize' according to the docs. I can update the patch
if needed.
next prev parent reply other threads:[~2015-02-03 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 21:46 [git-gui] bug report: "Open existing repository" dialog fails on submodules Rémi Rampin
2015-02-02 8:41 ` Chris Packham
2015-02-02 8:43 ` Chris Packham
2015-02-02 15:59 ` Rémi Rampin
2015-02-02 17:24 ` [PATCH 1/2] Fixes _is_git Remi Rampin
2015-02-02 17:24 ` [PATCH 2/2] Makes _do_open2 set _gitdir to actual path Remi Rampin
2015-02-03 8:51 ` Chris Packham
2015-02-03 16:00 ` Rémi Rampin [this message]
2015-02-03 8:44 ` [PATCH 1/2] Fixes _is_git Chris Packham
2015-02-03 15:52 ` Rémi Rampin
2015-02-05 8:13 ` Chris Packham
2015-02-05 16:20 ` [PATCH 0/2] gitfile support git git-gui Remi Rampin
2015-02-05 16:20 ` [PATCH 1/2] Fixes chooser not accepting gitfiles Remi Rampin
2015-02-05 16:20 ` [PATCH 2/2] Makes chooser set 'gitdir' to the resolved path Remi Rampin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D0F0A9.3080607@gmail.com \
--to=remirampin@gmail.com \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).