From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jeff King <peff@peff.net>, David Glasser <glasser@davidglasser.net>
Cc: git@vger.kernel.org, Fabian Ruch <bafain@gmail.com>
Subject: Re: Keep original author with git merge --squash?
Date: Thu, 12 Feb 2015 12:35:48 +0100 [thread overview]
Message-ID: <54DC9014.1010200@alum.mit.edu> (raw)
In-Reply-To: <20150212092824.GA19626@peff.net>
On 02/12/2015 10:28 AM, Jeff King wrote:
> On Wed, Feb 11, 2015 at 09:21:04AM -0800, David Glasser wrote:
>
>> (I'm not sure if this should be a flag to --squash or to commit.
>> Maybe `git merge --squash`; `git commit --use-squashed-author`? Seems
>> like it should be not too hard to implement; SQUASH_MSG is pretty
>> parseable. Or just a config value.)
>
> It sounds like "git commit -c" is close to what you want, which will
> pull the author and commit message from a particular commit. But I don't
> think there is a convenient way to name the commit in your case (it is
> likely to be the first commit on the branch you are squash-merging, but
> there isn't a shorthand for that).
>
> I assume you are already munging in your editor the template provided by
> "git commit" after the squash? What would be really nice, IMHO, is if
> there was a way to set the author during that edit (e.g., by moving one
> of the "Author:" lines to the top of the file). That would cover your
> use case, I think, and would also be useful in general.
If only Git supported options on todo list lines [1], this could be
implemented via a "--use-author" option:
pick --use-author 1234556 blah
squash 84392ab etc
fixup 49106a5 another
Happily, this would work with fixup, too, without forcing the user to go
into the editor. Also, it wouldn't require metadata to be read in-band
from the commit message.
Michael
[1] http://article.gmane.org/gmane.comp.version-control.git/255410
--
Michael Haggerty
mhagger@alum.mit.edu
next prev parent reply other threads:[~2015-02-12 11:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 17:21 Keep original author with git merge --squash? David Glasser
2015-02-12 9:28 ` Jeff King
2015-02-12 11:35 ` Michael Haggerty [this message]
2015-02-12 12:12 ` Jeff King
2015-02-12 18:42 ` David Glasser
2015-02-12 20:18 ` Junio C Hamano
2015-02-12 20:53 ` David Glasser
2015-02-12 21:23 ` Junio C Hamano
2015-02-12 22:16 ` David Glasser
2015-02-12 22:19 ` David Glasser
2015-02-12 22:34 ` Junio C Hamano
2015-02-12 22:50 ` Jeff King
2015-02-12 23:32 ` Junio C Hamano
2015-02-13 7:10 ` Jeff King
2015-02-13 19:30 ` Junio C Hamano
2015-02-13 19:55 ` Jeff King
2015-02-13 0:17 ` David Glasser
2015-02-13 0:21 ` David Glasser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DC9014.1010200@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=bafain@gmail.com \
--cc=git@vger.kernel.org \
--cc=glasser@davidglasser.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).