From: Karsten Blees <karsten.blees@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH 0/3] Win32: nanosecond-precision file times
Date: Thu, 12 Feb 2015 23:57:30 +0100 [thread overview]
Message-ID: <54DD2FDA.7030604@gmail.com> (raw)
In-Reply-To: <xmqqbnkysygl.fsf@gitster.dls.corp.google.com>
Am 12.02.2015 um 20:48 schrieb Junio C Hamano:
> Karsten Blees <karsten.blees@gmail.com> writes:
>
>> However, some users have expressed concerns that 'same size and
>> mtime' [2] may theoretically happen by chance in daily operation.
>
> Hmph.
>
> Haven't we already accepted that it is not just "may theoretically
> happen" and had counter-measures in racy-git detection machinery
> for quite some time?
>
Racy-git only triggers for files that are modified at the same time
as .git/index (i.e. we don't know if the stat cache is up to date).
This is more about copying 'old' things around, which usually also
copies mtime on Windows. E.g.:
# create two files with slightly different mtime
for i in {1..10}; do (echo "v1" >> test); done &&
for i in {1..10}; do (echo "v2" >> test2); done
# wait a bit so that '.git/index' is always newer than 'test' / 'test2'
sleep 1
git add test
git commit -m v1
# copy test2 over test (similar to 'cp -p', but native 'copy' also
# copies mtime nanoseconds)
cmd //c "copy /y test2 test"
git add test
git commit -m v2
Without these patches, git does not detect the change, and the second
git add / git commit are noops.
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-02-12 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 23:49 [PATCH 0/3] Win32: nanosecond-precision file times Karsten Blees
2015-02-11 23:51 ` [PATCH 1/3] Win32: make FILETIME conversion functions public Karsten Blees
2015-02-11 23:52 ` [PATCH 2/3] Win32: replace MSVCRT's fstat() with a Win32-based implementation Karsten Blees
2015-02-11 23:53 ` [PATCH 3/3] Win32: implement nanosecond-precision file times Karsten Blees
2015-02-12 23:15 ` Thomas Braun
2015-02-12 23:44 ` Karsten Blees
2015-02-12 19:48 ` [PATCH 0/3] Win32: " Junio C Hamano
2015-02-12 22:30 ` Johannes Schindelin
2015-02-12 22:57 ` Karsten Blees [this message]
2015-02-12 23:38 ` Junio C Hamano
2015-02-13 1:59 ` Karsten Blees
2015-02-13 19:28 ` Junio C Hamano
2015-02-16 20:18 ` Karsten Blees
2015-02-16 22:10 ` Junio C Hamano
2015-02-17 21:57 ` Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DD2FDA.7030604@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).