From: "Torsten Bögershausen" <tboegi@web.de>
To: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Cc: lists@hcf.yourweb.de,
"sandals@crustytoothpaste.net >> brian m. carlson"
<sandals@crustytoothpaste.net>
Subject: Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git
Date: Sun, 22 Feb 2015 18:57:34 +0100 [thread overview]
Message-ID: <54EA188E.9090601@web.de> (raw)
In-Reply-To: <54E8A9D0.30108@web.de>
(Sorry for the spam, a few things need correction already now,
and forgot cc: Brian)
On 2015-02-21 16.52, Torsten Bögershausen wrote:
> The ssh:// syntax was added in 2386d65822c91, it accepted
> ssh://user@2001:db8::1/repo.git, which is now legacy.
>
> Over the years the parser was improved to support [] and port numbers,
> but the combination of ssh://user@[2001:db8::1]:222/repo.git did
> never work.
s/did never work/was never implemented/
>
> The only only way to use a user name, a literall IPV6 address and a port
s/literall/literal/
> number was ssh://[user@2001:db8::1]:222/repo.git
>
> (Thanks to Christian Taube <lists@hcf.yourweb.de> for reporting this long
> standing issue)
>
> New users would use ssh://user@[2001:db8::1]:222/repo.git,
> so change the parser to handle it correctly.
>
> Support the old legacy URL's as well, to be backwards compatible,
s/URL's/URLs/
next prev parent reply other threads:[~2015-02-22 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 15:52 [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git Torsten Bögershausen
2015-02-22 17:57 ` Torsten Bögershausen [this message]
2015-02-22 19:37 ` Junio C Hamano
2015-02-23 0:23 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EA188E.9090601@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=lists@hcf.yourweb.de \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox