git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] daemon: use strbuf for hostname info
Date: Sat, 07 Mar 2015 11:49:49 +0100	[thread overview]
Message-ID: <54FAD7CD.4020408@web.de> (raw)
In-Reply-To: <20150307010832.GB8202@peff.net>

Am 07.03.2015 um 02:08 schrieb Jeff King:
> On Sat, Mar 07, 2015 at 01:20:22AM +0100, René Scharfe wrote:
>
>>> Not a big deal, but do we want to rename sanitize_client_strbuf to
>>> sanitize_client? It only had the unwieldy name to distinguish it from
>>> this one.
>>
>> A patch would look like this.  The result is shorter, but no win in
>> terms of vertical space (number of lines).
>
> IMHO this is an improvement, though whether it is enough to merit the
> code churn I dunno. So I'm in favor, but don't mind dropping it if
> others disagree.

I don't think the change justifies a separate patch, but we can squash 
it in. :)

René

  reply	other threads:[~2015-03-07 10:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  8:57 [PATCH] daemon: use strbuf for hostname info René Scharfe
2015-03-06 21:06 ` Jeff King
2015-03-07  0:20   ` René Scharfe
2015-03-07  1:08     ` Jeff King
2015-03-07 10:49       ` René Scharfe [this message]
2015-03-07  0:54   ` René Scharfe
2015-03-07  1:07     ` Jeff King
2015-03-07 10:50 ` [PATCH v2 1/2] " René Scharfe
2015-03-07 10:50 ` [PATCH v2 2/2] daemon: deglobalize hostname information René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FAD7CD.4020408@web.de \
    --to=l.s.r@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).