From: "Torsten Bögershausen" <tboegi@web.de>
To: Stefan Beller <sbeller@google.com>, gitster@pobox.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] connect.c: Fix memory leak
Date: Mon, 09 Mar 2015 20:23:59 +0100 [thread overview]
Message-ID: <54FDF34F.60608@web.de> (raw)
In-Reply-To: <1425920304-22360-1-git-send-email-sbeller@google.com>
On 2015-03-09 17.58, Stefan Beller wrote:
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> connect.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/connect.c b/connect.c
> index ce0e121..6090211 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -739,6 +739,7 @@ struct child_process *git_connect(int fd[2], const char *url,
>
> free(hostandport);
> free(path);
> + free(conn);
> return NULL;
> } else {
> ssh = getenv("GIT_SSH_COMMAND");
>
Nice catch, thanks.
(Even if it is not sooo serious today, the current implementation of Git just dies
when connection is NULL)
next prev parent reply other threads:[~2015-03-09 19:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 16:58 [PATCH 1/3] connect.c: Fix memory leak Stefan Beller
2015-03-09 16:58 ` [PATCH 2/3] bundle.c: fix " Stefan Beller
2015-03-10 22:40 ` Junio C Hamano
2015-03-10 23:08 ` Stefan Beller
2015-03-10 23:17 ` Junio C Hamano
2015-03-10 23:51 ` Stefan Beller
2015-03-11 3:57 ` Junio C Hamano
2015-03-09 16:58 ` [PATCH 3/3] builtin/help.c: " Stefan Beller
2015-03-10 22:43 ` Junio C Hamano
2015-03-10 23:50 ` Stefan Beller
2015-03-11 3:52 ` Junio C Hamano
2015-03-09 19:23 ` Torsten Bögershausen [this message]
2015-03-10 22:35 ` [PATCH 1/3] connect.c: Fix " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FDF34F.60608@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).