Git development
 help / color / mirror / Atom feed
From: Marc Strapetz <marc.strapetz@syntevo.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Taylor Blau <me@ttaylorr.com>,
	Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH 0/3] send-pack: avoid resending unchanged objects after rebasing
Date: Wed, 4 Nov 2026 18:13:55 +0100	[thread overview]
Message-ID: <54bbe02c-3319-477e-a9d9-024ef7027142@syntevo.com> (raw)
In-Reply-To: <pull.2281.git.1793029565.gitgitgadget@gmail.com>

On 26/10/2026 16:46, Marc Strapetz via GitGitGadget wrote:
> This series teaches send-pack to request inspection of the old tip's tree
> before packing, so more receiver-known objects can be excluded.
I'd like to give this series one more try, because I think the default
push path still misses a worthwhile optimization opportunity.

Rebase-and-force-update workflows are common enough that avoiding
redundant transfer on the default path appears worth evaluating. Junio
pointed out that push negotiation addresses the same general problem.
This series instead targets the non-negotiated default path: it uses the
already advertised old destination tip, with no additional round trip,
server change, or protocol change.

For qualifying non-fast-forward branch updates, this series can avoid
resending objects already present at the destination. This can reduce
pack size and network transfer, as well as client-side packing and
server-side receive and indexing work. The scope is narrow: ordinary
fast-forward pushes are unaffected, and the additional inspection is
limited to forced updates with a locally available old tip.

The current measurements show both the potential and the tradeoff: the
small cases improve, while the low-benefit worst-case fixture adds about
8% packing time for a negligible size reduction. These measurements
cover only local pack generation; they do not include the primary
expected benefits of a smaller pack: reduced network transfer and less
receive and indexing work on the server. I would appreciate another look
at whether this targeted optimization is worthwhile on the default path,
and whether its current scope is narrow enough.

I've added Taylor and Derrick because of their work on pack generation
and revision traversal. I'd be interested to hear whether this looks
like a reasonable tradeoff for rewritten branch updates, or whether
there is a simpler approach worth exploring.

-Marc





      parent reply	other threads:[~2026-11-04 17:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 15:46 [PATCH 0/3] send-pack: avoid resending unchanged objects after rebasing Marc Strapetz via GitGitGadget
2026-10-26 15:46 ` [PATCH 1/3] t5516: record redundant blobs " Marc Strapetz via GitGitGadget
2026-10-26 15:46 ` [PATCH 2/3] pack-objects: inspect selected haves for shared objects Marc Strapetz via GitGitGadget
2026-10-26 15:46 ` [PATCH 3/3] send-pack: avoid resending unchanged blobs after rebasing Marc Strapetz via GitGitGadget
2026-10-26 17:26 ` [PATCH 0/3] send-pack: avoid resending unchanged objects " Junio C Hamano
2026-10-26 21:23   ` Marc Strapetz
2026-11-04 17:13 ` Marc Strapetz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54bbe02c-3319-477e-a9d9-024ef7027142@syntevo.com \
    --to=marc.strapetz@syntevo.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox