From: Alban Gruin <alban.gruin@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: gitster@pobox.com, git@vger.kernel.org, phillip.wood123@gmail.com
Subject: Re: ag/sequencer-todo-updates , was Re: What's cooking in git.git (Nov 2019, #03; Tue, 19)
Date: Sat, 23 Nov 2019 01:47:10 +0100 [thread overview]
Message-ID: <54cf0a3d-9b05-b24f-7bb1-983c8d3354df@gmail.com> (raw)
In-Reply-To: <20191119204146.168001-1-jonathantanmy@google.com>
Hi Jonathan,
Le 19/11/2019 à 21:41, Jonathan Tan a écrit :
> - Commit 3's todo_list_write_total_nr() could just take an int instead
> of the full "struct todo_list *".
>
I’m not really sure about this. This way, it can only write a specific
integer from a specific data structure, and cannot easily be misused to
write something else.
Cheers,
Alban
next prev parent reply other threads:[~2019-11-23 0:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 7:05 What's cooking in git.git (Nov 2019, #03; Tue, 19) Junio C Hamano
2019-11-19 9:38 ` Danh Doan
2019-11-20 2:52 ` Junio C Hamano
2019-11-19 17:58 ` SZEDER Gábor
2019-11-20 3:02 ` Junio C Hamano
2019-11-20 13:58 ` Derrick Stolee
2019-11-21 0:36 ` Junio C Hamano
2019-11-21 11:10 ` Derrick Stolee
2019-11-22 5:42 ` Junio C Hamano
2019-11-19 18:01 ` ag/sequencer-todo-updates , was " Alban Gruin
2019-11-19 20:41 ` Jonathan Tan
2019-11-20 3:03 ` Junio C Hamano
2019-11-21 8:17 ` Alban Gruin
2019-11-23 0:47 ` Alban Gruin [this message]
2019-11-20 23:32 ` Denton Liu
2019-11-21 0:39 ` Junio C Hamano
2019-11-23 20:35 ` Philippe Blain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54cf0a3d-9b05-b24f-7bb1-983c8d3354df@gmail.com \
--to=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).