git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] t3700-add: added test for --exclude option
Date: Sun, 15 Mar 2015 19:00:58 +0100	[thread overview]
Message-ID: <5505C8DA.2050500@web.de> (raw)
In-Reply-To: <1426427437-23370-1-git-send-email-kuleshovmail@gmail.com>

> +test_expect_success 'Test that "git add --exclude" works' '
> +	touch foo &&
> +	touch bar &&
can be written shorter as
        >foo &&
	>bar &&
> +	git add --exclude="bar" . &&
Side question:
Do we need "" here ?
Or should we test files with white space as well, like this:
        >foo &&
	>bar &&
	>"b a z" &&
    	git add --exclude="bar" --exclude="b a z" . &&
	echo bar >expect &&
	git ls-files >actual &&
	test_cmp expect actual
(Which doesn't use ! grep, but test_cmp, which will give more information when
the test case does not pass)

  reply	other threads:[~2015-03-15 18:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15 13:49 [PATCH RFC 1/3] add: add new --exclude option to git add Alexander Kuleshov
2015-03-15 13:50 ` [PATCH 2/3] Documentation/git-add.txt: describe --exclude option Alexander Kuleshov
2015-03-15 18:14   ` Eric Sunshine
2015-03-15 13:50 ` [PATCH 3/3] t3700-add: added test for " Alexander Kuleshov
2015-03-15 18:00   ` Torsten Bögershausen [this message]
2015-03-15 18:18   ` Eric Sunshine
2015-03-15 17:39 ` [PATCH RFC 1/3] add: add new --exclude option to git add Philip Oakley
2015-03-15 17:51 ` Torsten Bögershausen
2015-03-15 18:00   ` Alexander Kuleshov
2015-03-16  6:38     ` Torsten Bögershausen
2015-03-15 18:03   ` Torsten Bögershausen
2015-03-15 18:12 ` Eric Sunshine
2015-03-15 20:09   ` Junio C Hamano
2015-03-15 21:12     ` Philip Oakley
2015-03-15 21:50       ` Junio C Hamano
2015-03-16  7:11         ` Alexander Kuleshov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5505C8DA.2050500@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kuleshovmail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).