From: "Torsten Bögershausen" <tboegi@web.de>
To: Koosha Khajehmoogahi <koosha@posteo.de>,
Eric Sunshine <sunshine@sunshineco.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>, "Git List" <git@vger.kernel.org>
Subject: Re: [PATCH 4/5] Add tests for git-log --merges=show|hide|only
Date: Mon, 23 Mar 2015 06:14:24 +0100 [thread overview]
Message-ID: <550FA130.1030402@web.de> (raw)
In-Reply-To: <550F450F.6070207@posteo.de>
Back to the original discussion:
+test_expect_success 'log with config log.merges=show' '
+ git config log.merges show &&
+ git log --pretty=tformat:%s >actual &&
+ test_cmp both_commits_merges actual &&
+ git config --unset log.merges
These days I would probably shorten the code, the review time and
the execution time of the test and increase the clean-ness with 50%
by simply writing
+test_expect_success 'log with config log.merges=show' '
+ git -c log.merges=show log --pretty=tformat:%s >actual &&
+ test_cmp both_commits_merges actual
+ '
next prev parent reply other threads:[~2015-03-23 5:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 18:28 [PATCH 1/5] Add a new option 'merges' to revision.c Koosha Khajehmoogahi
2015-03-22 18:28 ` [PATCH 2/5] Make git-log honor log.merges option Koosha Khajehmoogahi
2015-03-22 20:50 ` Eric Sunshine
2015-03-22 18:28 ` [PATCH 3/5] Update documentations for git-log to include the new --merges option and also its corresponding config option Koosha Khajehmoogahi
2015-03-22 21:17 ` Eric Sunshine
2015-03-22 18:28 ` [PATCH 4/5] Add tests for git-log --merges=show|hide|only Koosha Khajehmoogahi
2015-03-22 19:57 ` Torsten Bögershausen
2015-03-22 20:19 ` Eric Sunshine
2015-03-22 22:07 ` Koosha Khajehmoogahi
2015-03-22 22:40 ` Eric Sunshine
2015-03-22 22:41 ` Koosha Khajehmoogahi
2015-03-23 5:14 ` Torsten Bögershausen [this message]
2015-03-22 22:26 ` Eric Sunshine
2015-03-22 18:28 ` [PATCH 5/5] Update Bash completion script to include git log --merges option Koosha Khajehmoogahi
2015-03-22 21:24 ` Eric Sunshine
2015-03-23 1:23 ` SZEDER Gábor
2015-03-22 20:43 ` [PATCH 1/5] Add a new option 'merges' to revision.c Eric Sunshine
2015-03-22 23:31 ` Junio C Hamano
2015-03-23 0:42 ` Koosha Khajehmoogahi
2015-03-23 1:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550FA130.1030402@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=koosha@posteo.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).