git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tom Clarke" <tom@u2i.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH] Adding rebase merge strategy
Date: Mon, 1 Oct 2007 23:41:56 +0200	[thread overview]
Message-ID: <550f9510710011441t1eb50352ofc8db77f79d794d5@mail.gmail.com> (raw)
In-Reply-To: <7vr6ker1lf.fsf@gitster.siamese.dyndns.org>

On 10/1/07, Junio C Hamano <gitster@pobox.com> wrote:
> This would give a handier shortcut iff the rebase goes well, but
> the workflow after stopping would be entirely different from the
> normal "merge".  I am a bit worried about it giving confusion to
> the end users.

Thanks for the ample feedback, you raise a number of interesting
issues. I am wondering now if making rebase a merge strategy is really
a good idea. Rebasing is not merging, a difference that could perhaps
be overlooked in the no-conflict scenario, but as you point out, is
glaringly obvious as soon as you have conflicts.

I'm happy to try to address the issues you raised, but I wonder if we
would do better to look back at my original proposal which was to add
a --rebase option to git-pull. git-pull is the main place there I see
need for using a rebase instead of a merge, as anywhere where you
might use git-merge directly, if what you really want is a rebase, you
can just run git-rebase.

-Tom

  reply	other threads:[~2007-10-01 21:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 16:15 [PATCH] Adding rebase merge strategy Tom Clarke
2007-09-28 17:03 ` Johannes Schindelin
2007-09-28 17:18   ` Tom Clarke
2007-10-01 15:08   ` Tom Clarke
2007-10-01 15:50     ` Johannes Schindelin
2007-10-01 21:01     ` Junio C Hamano
2007-10-01 21:41       ` Tom Clarke [this message]
2007-10-01 22:17         ` Carl Worth
2007-10-01 22:21           ` Tom Clarke
2007-10-01 22:30             ` Shawn O. Pearce
2007-10-01 22:53               ` Carl Worth
2007-10-01 23:11                 ` Junio C Hamano
2007-10-02 10:00               ` Johannes Schindelin
2007-10-02 10:29                 ` Tom Clarke
2007-10-02 18:40                   ` Junio C Hamano
2007-10-03 14:11                     ` Tom Clarke
2007-10-03 15:54                       ` Johannes Schindelin
2007-10-01 23:09           ` J. Bruce Fields
2007-10-01 22:28         ` Junio C Hamano
     [not found] <11885023904126-git-send-email-tom@u2i.com>
2007-08-30 19:36 ` Tom Clarke
2007-08-30 19:53   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550f9510710011441t1eb50352ofc8db77f79d794d5@mail.gmail.com \
    --to=tom@u2i.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).