From: "Jakub Narębski" <jnareb@gmail.com>
To: "Jérôme Zago" <git-patch@agt-the-walker.net>
Cc: git@vger.kernel.org, Junio Hamano <gitster@pobox.com>
Subject: Re: [PATCH] gitweb.conf.txt: fix typo
Date: Tue, 31 Mar 2015 15:06:49 +0200 [thread overview]
Message-ID: <551A9BE9.3070907@gmail.com> (raw)
In-Reply-To: <1396558187-5674-1-git-send-email-git-patch@agt-the-walker.net>
On 2014-04-03 at 22:49, git-patch@agt-the-walker.net wrote:
> From: Jérôme Zago <git-patch@agt-the-walker.net>
>
> "build-time" is used everywhere else.
>
> Signed-off-by: Jérôme Zago <git-patch@agt-the-walker.net>
You are right, it is variable set during build process,
not after project is built.
ACK (for what it is worth).
Acked-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Documentation/gitweb.conf.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt
> index 952f503..8b25a2f 100644
> --- a/Documentation/gitweb.conf.txt
> +++ b/Documentation/gitweb.conf.txt
> @@ -482,7 +482,7 @@ project config. Per-repository configuration takes precedence over value
> composed from `@git_base_url_list` elements and project name.
> +
> You can setup one single value (single entry/item in this list) at build
> -time by setting the `GITWEB_BASE_URL` built-time configuration variable.
> +time by setting the `GITWEB_BASE_URL` build-time configuration variable.
> By default it is set to (), i.e. an empty list. This means that gitweb
> would not try to create project URL (to fetch) from project name.
>
>
next prev parent reply other threads:[~2015-03-31 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 20:49 [PATCH] gitweb.conf.txt: fix typo git-patch
2015-03-31 13:06 ` Jakub Narębski [this message]
2015-03-31 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551A9BE9.3070907@gmail.com \
--to=jnareb@gmail.com \
--cc=git-patch@agt-the-walker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).