git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@ubuntu.com>
To: Duy Nguyen <pclouds@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Clone from shallow bundle bug
Date: Wed, 01 Apr 2015 21:26:50 -0400	[thread overview]
Message-ID: <551C9ADA.50404@ubuntu.com> (raw)
In-Reply-To: <CACsJy8Cew0t9EZ5aVSCa-BehWz+ABRhDbtLR2cJ2K9c38QeGsA@mail.gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 04/01/2015 08:33 PM, Duy Nguyen wrote:
> OK two additional options on top of what we already have:
> 
> - save .have and add extra prerequisite SHA-1. - create a bundle
> that does not hit shallow boundary in the first place, roughly
> speaking it's "max depth minus one". This one does not have extra
> .have or prerequisites

Huh?  If it is one less deep that doesn't help: the new clone will
still be missing history.  AFAICS, the only way to keep the new clone
kosher is for it to have a .git/shallow file that identifies it as a
shallow clone so that history walks stop short instead of complaining
about the missing history.

Thus, all that is needed is for the clone, when it notices that
history is missing, is to create the shallow file instead of erroring
out, telling you to fsck yourself, and rudely deleting the new clone.
 It is one thing to tell you that there is missing history, but quite
another to delete the repository it just created due to it missing
history.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCgAGBQJVHJraAAoJENRVrw2cjl5RABEH/RW+J5eFNRL80qMVSSnYI4Wb
RjCb5Lb1pp4PBQtGK6yJ/7lzDYptAN6aLcpMVrGiyIIJDm7KfZ6rGvhUegn37ImH
dCelZs+XHeR1dVd05Lbn9FGgB3mg873JOb5+i/hMuuudrXhNjRy6hhFGBnVulpPP
lySfaPMscbSH7lzqr1zxgdu4GzRLlLPzKv1ojiWGyy97iRAsN6bRy6I1/wsddKMn
hESUlv7AdTNQxu3b3NsLGS20a9QHMpKjBxBLvOYE6ftr4yyHMkxum/+BnoASY2UB
h5LenKnQzRwFNGiw1BDeQESqYDXpQ4yA7lpd91gsINwgVsRqg82iSen9/fszzq0=
=shT5
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2015-04-02  1:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31 21:10 Clone from shallow bundle bug Phillip Susi
2015-03-31 22:17 ` Junio C Hamano
2015-04-01  2:56   ` Phillip Susi
2015-04-01  6:31     ` Junio C Hamano
2015-04-01 10:01       ` Duy Nguyen
2015-04-01 13:00         ` Phillip Susi
2015-04-01 17:20         ` Junio C Hamano
2015-04-02  0:33           ` Duy Nguyen
2015-04-02  0:35             ` Duy Nguyen
2015-04-02  1:26             ` Phillip Susi [this message]
2015-04-01  9:55 ` Duy Nguyen
2015-04-01 12:53   ` Phillip Susi
2015-04-01 13:09     ` Duy Nguyen
2015-04-01 13:30       ` Phillip Susi
2015-04-01 13:36         ` Duy Nguyen
2015-04-01 14:06           ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551C9ADA.50404@ubuntu.com \
    --to=psusi@ubuntu.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).