git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Notes do not follow rebase
@ 2015-04-08 18:40 Phillip Susi
  2015-04-08 22:56 ` Johan Herland
  0 siblings, 1 reply; 2+ messages in thread
From: Phillip Susi @ 2015-04-08 18:40 UTC (permalink / raw)
  To: git@vger.kernel.org

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

After doing a rebase -i to fix up some older commits, I noticed that
notes I had associated with commits failed to follow the commit across
the rebase, so the notes are now orphaned and will be pruned.
Shouldn't notes be copied to the new commit during an ammend/rebase?



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVJXY7AAoJENRVrw2cjl5RUe8IAI0tGUeBUAef4xIIU/UfV5eQ
VAdkUfYXCHnkjqukS/iBusyNM3PssabHmRFc+AdKGPPmbsv9JGKpj5G9hwf6Bdh+
RNDPMTlt/Ii90eu+v3uXwFHNUNf0b6kv7Tw63L0bFxGsFzu55DBm48LT/DJ9T05x
Yqz5hbisKAhiVfAep2ib32f8gvC6p47CBmKVY4ii/PpOIzX/clZOQEgSPxvuHcSR
cVcMGdljG+n8UqEOkkX5im0cW7pOUUht5GXWRGnBjXjtKTG64zxZnBPsPcqVJtxT
q/lloKerUktJH3bJbUDU6iefBBzukQyy6tF37nbZH68bwTBlrh8CGL1BT2Eviqs=
=WyFy
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Notes do not follow rebase
  2015-04-08 18:40 Notes do not follow rebase Phillip Susi
@ 2015-04-08 22:56 ` Johan Herland
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Herland @ 2015-04-08 22:56 UTC (permalink / raw)
  To: Phillip Susi; +Cc: git@vger.kernel.org

On Wed, Apr 8, 2015 at 8:40 PM, Phillip Susi <psusi@ubuntu.com> wrote:
> After doing a rebase -i to fix up some older commits, I noticed that
> notes I had associated with commits failed to follow the commit across
> the rebase, so the notes are now orphaned and will be pruned.
> Shouldn't notes be copied to the new commit during an ammend/rebase?

It depends. Which notes do you want copied? (i.e. from which notes
ref?) Please have a look at the notes.rewriteRef config option
(documented in the git-config and git-notes manual pages)

...Johan


-- 
Johan Herland, <johan@herland.net>
www.herland.net

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-08 22:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-08 18:40 Notes do not follow rebase Phillip Susi
2015-04-08 22:56 ` Johan Herland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).