From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?B?UmVuw6kgU2NoYXJmZQ==?= <l.s.r@web.de>
Subject: Re: [PATCH] git-gui: sort entries in tclIndex
Date: Sat, 25 Apr 2015 18:27:11 +0200
Message-ID: <553BC05F.1070702@web.de>
References: <1422292043-12711-1-git-send-email-olaf@aepfle.de> <20150210151803.GB8965@aepfle.de> <20150415072251.GA18595@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>
To: Olaf Hering <olaf@aepfle.de>, git@vger.kernel.org
X-From: git-owner@vger.kernel.org Sat Apr 25 18:28:29 2015
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@plane.gmane.org
Received: from vger.kernel.org ([209.132.180.67])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <git-owner@vger.kernel.org>)
	id 1Ym2wM-0007NK-PE
	for gcvg-git-2@plane.gmane.org; Sat, 25 Apr 2015 18:28:27 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755819AbbDYQ1e (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sat, 25 Apr 2015 12:27:34 -0400
Received: from mout.web.de ([212.227.15.4]:55367 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754637AbbDYQ1e (ORCPT <rfc822;git@vger.kernel.org>);
	Sat, 25 Apr 2015 12:27:34 -0400
Received: from [192.168.178.27] ([79.253.129.13]) by smtp.web.de (mrweb002)
 with ESMTPSA (Nemesis) id 0MYNkX-1Yq9dC0wdN-00VAEd; Sat, 25 Apr 2015 18:27:31
 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
In-Reply-To: <20150415072251.GA18595@aepfle.de>
X-Provags-ID: V03:K0:DBWzF4jYWGUh9eOixymPyKE0q2numxp5VPhcXBcUEOeDwPGucJo
 JQgCYAS36MCSwbVq8SuTQ7ExhlTO/9Gbvf6gk8eN5Do1usCZjaj+Cu4GZqWbd0LnrInpm0H
 XTZ3iom2pV1XH3dr3lTG40j7GQWtdFN+9afdXKD9pejhDQGFgooqj0Y/IfgKFVPzWGJDz8I
 BzZGe9tDo8wtb/RH62pZg==
X-UI-Out-Filterresults: notjunk:1;
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/267791>

Looping in Pat (git-gui maintainer).

Am 15.04.2015 um 09:22 schrieb Olaf Hering:
> Ping?
>
> On Tue, Feb 10, Olaf Hering wrote:
>
>> Ping?
>>
>> On Mon, Jan 26, Olaf Hering wrote:
>>
>>> ALL_LIBFILES uses wildcard, which provides the result in directory
>>> order. This order depends on the underlying filesystem on the
>>> buildhost. To get reproducible builds it is required to sort such list
>>> before using them.
>>>
>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>> ---
>>>   git-gui/Makefile | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/git-gui/Makefile b/git-gui/Makefile
>>> index cde8b2e..7564a18 100644
>>> --- a/git-gui/Makefile
>>> +++ b/git-gui/Makefile
>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>>>   	 rm -f $@ ; \
>>>   	 echo '# Autogenerated by git-gui Makefile' >$@ && \
>>>   	 echo >>$@ && \
>>> -	 $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
>>> +	 $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>   	 echo >>$@ ; \
>>>   	fi
>>>