* [PATCH] git-gui: sort entries in tclIndex
@ 2015-01-26 17:07 Olaf Hering
2015-02-10 15:18 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2015-01-26 17:07 UTC (permalink / raw)
To: git; +Cc: Olaf Hering
ALL_LIBFILES uses wildcard, which provides the result in directory
order. This order depends on the underlying filesystem on the
buildhost. To get reproducible builds it is required to sort such list
before using them.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
git-gui/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index cde8b2e..7564a18 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
rm -f $@ ; \
echo '# Autogenerated by git-gui Makefile' >$@ && \
echo >>$@ && \
- $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
+ $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
echo >>$@ ; \
fi
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: sort entries in tclIndex
2015-01-26 17:07 [PATCH] git-gui: sort entries in tclIndex Olaf Hering
@ 2015-02-10 15:18 ` Olaf Hering
2015-04-15 7:22 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2015-02-10 15:18 UTC (permalink / raw)
To: git
Ping?
On Mon, Jan 26, Olaf Hering wrote:
> ALL_LIBFILES uses wildcard, which provides the result in directory
> order. This order depends on the underlying filesystem on the
> buildhost. To get reproducible builds it is required to sort such list
> before using them.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> git-gui/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-gui/Makefile b/git-gui/Makefile
> index cde8b2e..7564a18 100644
> --- a/git-gui/Makefile
> +++ b/git-gui/Makefile
> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> rm -f $@ ; \
> echo '# Autogenerated by git-gui Makefile' >$@ && \
> echo >>$@ && \
> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
> echo >>$@ ; \
> fi
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: sort entries in tclIndex
2015-02-10 15:18 ` Olaf Hering
@ 2015-04-15 7:22 ` Olaf Hering
2015-04-25 16:27 ` René Scharfe
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2015-04-15 7:22 UTC (permalink / raw)
To: git
Ping?
On Tue, Feb 10, Olaf Hering wrote:
> Ping?
>
> On Mon, Jan 26, Olaf Hering wrote:
>
> > ALL_LIBFILES uses wildcard, which provides the result in directory
> > order. This order depends on the underlying filesystem on the
> > buildhost. To get reproducible builds it is required to sort such list
> > before using them.
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > ---
> > git-gui/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/git-gui/Makefile b/git-gui/Makefile
> > index cde8b2e..7564a18 100644
> > --- a/git-gui/Makefile
> > +++ b/git-gui/Makefile
> > @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> > rm -f $@ ; \
> > echo '# Autogenerated by git-gui Makefile' >$@ && \
> > echo >>$@ && \
> > - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
> > + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
> > echo >>$@ ; \
> > fi
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: sort entries in tclIndex
2015-04-15 7:22 ` Olaf Hering
@ 2015-04-25 16:27 ` René Scharfe
2015-05-01 14:57 ` Pat Thoyts
0 siblings, 1 reply; 6+ messages in thread
From: René Scharfe @ 2015-04-25 16:27 UTC (permalink / raw)
To: Olaf Hering, git; +Cc: Pat Thoyts
Looping in Pat (git-gui maintainer).
Am 15.04.2015 um 09:22 schrieb Olaf Hering:
> Ping?
>
> On Tue, Feb 10, Olaf Hering wrote:
>
>> Ping?
>>
>> On Mon, Jan 26, Olaf Hering wrote:
>>
>>> ALL_LIBFILES uses wildcard, which provides the result in directory
>>> order. This order depends on the underlying filesystem on the
>>> buildhost. To get reproducible builds it is required to sort such list
>>> before using them.
>>>
>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>> ---
>>> git-gui/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/git-gui/Makefile b/git-gui/Makefile
>>> index cde8b2e..7564a18 100644
>>> --- a/git-gui/Makefile
>>> +++ b/git-gui/Makefile
>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>>> rm -f $@ ; \
>>> echo '# Autogenerated by git-gui Makefile' >$@ && \
>>> echo >>$@ && \
>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
>>> echo >>$@ ; \
>>> fi
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: sort entries in tclIndex
2015-04-25 16:27 ` René Scharfe
@ 2015-05-01 14:57 ` Pat Thoyts
2015-10-05 7:43 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Pat Thoyts @ 2015-05-01 14:57 UTC (permalink / raw)
To: René Scharfe; +Cc: Olaf Hering, git
René Scharfe <l.s.r@web.de> writes:
>Looping in Pat (git-gui maintainer).
>
>Am 15.04.2015 um 09:22 schrieb Olaf Hering:
>> Ping?
>>
>> On Tue, Feb 10, Olaf Hering wrote:
>>
>>> Ping?
>>>
>>> On Mon, Jan 26, Olaf Hering wrote:
>>>
>>>> ALL_LIBFILES uses wildcard, which provides the result in directory
>>>> order. This order depends on the underlying filesystem on the
>>>> buildhost. To get reproducible builds it is required to sort such list
>>>> before using them.
>>>>
>>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>>>> ---
>>>> git-gui/Makefile | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/git-gui/Makefile b/git-gui/Makefile
>>>> index cde8b2e..7564a18 100644
>>>> --- a/git-gui/Makefile
>>>> +++ b/git-gui/Makefile
>>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>>>> rm -f $@ ; \
>>>> echo '# Autogenerated by git-gui Makefile' >$@ && \
>>>> echo >>$@ && \
>>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>> echo >>$@ ; \
>>>> fi
>>>>
>
Applied. Thank you.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] git-gui: sort entries in tclIndex
2015-05-01 14:57 ` Pat Thoyts
@ 2015-10-05 7:43 ` Olaf Hering
0 siblings, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2015-10-05 7:43 UTC (permalink / raw)
To: Pat Thoyts; +Cc: René Scharfe, git
To which branch was this applied?
Its still broken in git-2.6.0.
Olaf
On Fri, May 01, Pat Thoyts wrote:
> René Scharfe <l.s.r@web.de> writes:
>
> >Looping in Pat (git-gui maintainer).
> >
> >Am 15.04.2015 um 09:22 schrieb Olaf Hering:
> >> Ping?
> >>
> >> On Tue, Feb 10, Olaf Hering wrote:
> >>
> >>> Ping?
> >>>
> >>> On Mon, Jan 26, Olaf Hering wrote:
> >>>
> >>>> ALL_LIBFILES uses wildcard, which provides the result in directory
> >>>> order. This order depends on the underlying filesystem on the
> >>>> buildhost. To get reproducible builds it is required to sort such list
> >>>> before using them.
> >>>>
> >>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> >>>> ---
> >>>> git-gui/Makefile | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/git-gui/Makefile b/git-gui/Makefile
> >>>> index cde8b2e..7564a18 100644
> >>>> --- a/git-gui/Makefile
> >>>> +++ b/git-gui/Makefile
> >>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> >>>> rm -f $@ ; \
> >>>> echo '# Autogenerated by git-gui Makefile' >$@ && \
> >>>> echo >>$@ && \
> >>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
> >>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
> >>>> echo >>$@ ; \
> >>>> fi
> >>>>
> >
>
> Applied. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-05 7:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-26 17:07 [PATCH] git-gui: sort entries in tclIndex Olaf Hering
2015-02-10 15:18 ` Olaf Hering
2015-04-15 7:22 ` Olaf Hering
2015-04-25 16:27 ` René Scharfe
2015-05-01 14:57 ` Pat Thoyts
2015-10-05 7:43 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).