From: karthik nayak <karthik.188@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Charles Bailey <charles@hashpling.org>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option
Date: Mon, 27 Apr 2015 17:27:27 +0530 [thread overview]
Message-ID: <553E2427.4090700@gmail.com> (raw)
In-Reply-To: <xmqqsiboyw90.fsf@gitster.dls.corp.google.com>
On 04/25/2015 10:34 PM, Junio C Hamano wrote:
> karthik nayak <karthik.188@gmail.com> writes:
>
> >> Is there any other way to make cat-file looser other than accepting
> >> an unknown type name from the future? If not, then perhaps it may
> >> make sense to give it a generic name that implies that we would
> >> trigger such additional looseness in the future. But as the
> >> inventor of it as a debugging aid, I would say a name that spells
> >> out the specific way this option is being loose, e.g.
> >>
> >>> --allow-bogus-type
> >>
> >> or with s/bogus/unknown/, best describes what it currently does.
> >
> > Yes this gives the best description, but its large, while we could use something
> > like --no-strict instead.
>
> We could, if you answered my first question with "no".
>
> By naming this "--no-strict", the first bug report you will receive
> may be that "cat-file --no-strict" should parse a zlib deflate that
> begins with "blob 1234\n\0" (notice that there are two SPs instead
> of the usual one, and length is followed by LF that should not be
> there before the NUL) but it does not.
>
> As your option name "--no-strict" signals that you will make the
> best effort to parse such nonsense, that would be a valid bug
> report, against which you would need to update the code to make it
> work. But is it worth the effort to make such a thing work? I
> dunno.
>
Nice point, I don't see the need to parse such objects at the moment.
That rules out "--no-strict" and everything similar.
I still find "--allow-unkown-type" a bit too big, what about something like
* --any-type
* --arbitrary-type
next prev parent reply other threads:[~2015-04-27 11:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 16:55 [PATCH v8 0/4] cat-file: teach cat-file a '--literally' option karthik nayak
2015-04-15 16:59 ` [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type Karthik Nayak
2015-04-15 20:21 ` Junio C Hamano
2015-04-15 22:18 ` Jeff King
2015-04-17 14:23 ` Jeff King
2015-04-17 16:21 ` Junio C Hamano
2015-04-17 20:51 ` Jeff King
2015-04-17 21:10 ` Junio C Hamano
2015-04-20 18:43 ` karthik nayak
2015-04-20 18:51 ` Jeff King
2015-04-21 11:26 ` karthik nayak
2015-04-21 14:24 ` Jeff King
2015-04-17 18:45 ` karthik nayak
2015-04-17 18:49 ` Jeff King
2015-04-18 8:31 ` karthik nayak
2015-04-17 19:23 ` Junio C Hamano
2015-04-18 8:32 ` karthik nayak
2015-04-17 23:31 ` Eric Sunshine
2015-04-18 9:03 ` karthik nayak
2015-04-15 16:59 ` [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option Karthik Nayak
2015-04-15 20:20 ` Junio C Hamano
2015-04-15 20:52 ` Junio C Hamano
2015-04-16 7:26 ` karthik nayak
2015-04-16 13:35 ` Junio C Hamano
2015-04-17 2:10 ` Karthik Nayak
2015-04-17 2:14 ` Junio C Hamano
2015-04-19 0:28 ` Charles Bailey
2015-04-20 5:30 ` Junio C Hamano
2015-04-20 7:44 ` Charles Bailey
2015-04-20 8:57 ` Karthik Nayak
2015-04-20 9:19 ` Charles Bailey
2015-04-20 15:52 ` karthik nayak
2015-04-21 10:16 ` Charles Bailey
2015-04-21 19:40 ` Eric Sunshine
2015-04-21 20:36 ` Junio C Hamano
2015-04-25 11:22 ` karthik nayak
2015-04-25 17:04 ` Junio C Hamano
2015-04-27 11:57 ` karthik nayak [this message]
2015-04-27 18:38 ` Eric Sunshine
2015-04-28 12:03 ` karthik nayak
2015-04-15 17:00 ` [PATCH v8 3/4] cat-file: add documentation for " Karthik Nayak
2015-04-15 17:00 ` [PATCH v8 4/4] t1006: add tests for git cat-file --literally Karthik Nayak
2015-04-18 0:00 ` Eric Sunshine
2015-04-18 5:22 ` karthik nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E2427.4090700@gmail.com \
--to=karthik.188@gmail.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).