git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: karthik nayak <karthik.188@gmail.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Git <git@vger.kernel.org>
Subject: Re: [PATCH v9 3/5] cat-file: teach cat-file a '--allow-unknown-type' option
Date: Wed, 29 Apr 2015 23:14:50 +0530	[thread overview]
Message-ID: <55411892.7060205@gmail.com> (raw)
In-Reply-To: <CABURp0qCe3aLtnwueh8Jm6Hm-AN1--Dk1NV4Y=oA5XhMsLh1Aw@mail.gmail.com>


On 04/29/2015 08:23 PM, Phil Hord wrote:
> On Wed, Apr 29, 2015 at 9:01 AM Karthik Nayak <karthik.188@gmail.com>
> wrote:
> >
> > Currently 'git cat-file' throws an error while trying to
> > print the type or size of a broken/corrupt object. This is
> > because these objects are usually of unknown types.
> >
> > Teach git cat-file a '--allow-unkown-type' option where it prints
> > the type or size of a broken/corrupt object without throwing
> > an error.
>
> In this entire series, replace all 'unkown' with 'unknown' in both the
> commit messages and the code ("unknown" is misspelled most of the
> time).  I notice the switch name itself is misspelled, but also
> variable names such as 'unkown_type' in this patch.
>
> Respectfully, because I know English is a challenging beast sometimes,
> and spelling is difficult even for many native speakers...
>
Thanks for that, Yes it does get a bit tricky with spellings, will find 
an editor with spellcheck and avoid nano :D

  reply	other threads:[~2015-04-29 17:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 12:50 [PATCH v9 0/5] cat-file: teach cat-file a '--allow-unkown-type' option karthik nayak
2015-04-29 12:52 ` [PATCH v9 1/5] sha1_file: support reading from a loose object of unknown type Karthik Nayak
2015-04-29 14:49   ` Junio C Hamano
2015-04-29 17:50     ` karthik nayak
2015-04-29 19:35       ` Junio C Hamano
2015-04-30  4:40         ` karthik nayak
2015-04-29 12:52 ` [PATCH v9 2/5] cat-file: make the options mutually exclusive Karthik Nayak
2015-04-29 12:53 ` [PATCH v9 3/5] cat-file: teach cat-file a '--allow-unknown-type' option Karthik Nayak
2015-04-29 14:52   ` Junio C Hamano
2015-04-29 17:43     ` karthik nayak
2015-04-29 14:53   ` Phil Hord
2015-04-29 17:44     ` karthik nayak [this message]
2015-04-29 19:38       ` Junio C Hamano
2015-04-29 12:54 ` [PATCH v9 5/5] t1006: add tests for git cat-file --allow-unkown-type Karthik Nayak
2015-04-29 21:16   ` Eric Sunshine
2015-04-29 12:56 ` [PATCH v9 4/5] cat-file: add documentation for '--allow-unkown-type' option Karthik Nayak
2015-04-29 21:13   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55411892.7060205@gmail.com \
    --to=karthik.188@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phil.hord@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).